Source/core/css/resolver/MatchedPropertiesCache.cpp - Issue 758073003: Always propagate direction and writing-mode from <body>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/MatchedPropertiesCache.cpp

Issue 758073003: Always propagate direction and writing-mode from <body>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added XML and overconstraining tests. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/writing-mode/xhtml-no-body-propagation-writing-mode-expected.xml ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/MatchedPropertiesCache.cpp

diff --git a/Source/core/css/resolver/MatchedPropertiesCache.cpp b/Source/core/css/resolver/MatchedPropertiesCache.cpp

index 9ccacbae42bb66f69ed6074b1116019cb5741f40..7b70393d135e0f908fc78c82eab8ffc9bda280ba 100644

--- a/Source/core/css/resolver/MatchedPropertiesCache.cpp

+++ b/Source/core/css/resolver/MatchedPropertiesCache.cpp

@@ -174,9 +174,6 @@ void MatchedPropertiesCache::sweep(Timer<MatchedPropertiesCache>*)

bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderStyle* style, const RenderStyle* parentStyle)

{

- // FIXME: CSSPropertyWebkitWritingMode modifies state when applying to document element. We can't skip the applying by caching.

- if (element == element->document().documentElement() && element->document().writingModeSetOnDocumentElement())

- return false;

if (style->unique() || (style->styleType() != NOPSEUDO && parentStyle->unique()))

return false;

if (style->hasAppearance())