Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 757553004: Set V8_CC_GNU or V8_CC_MSVC for clang in gcc / cl mode. (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Set V8_CC_GNU or V8_CC_MSVC for clang in gcc / cl mode. Also, remove V8_CC_CLANG since it's not read anywhere (and ideally shouldn't be). Clang tries to be compatible with gcc in clang mode, and with msvc in clang-cl mode. It wants to go down the same code paths that these compilers want to go down in most cases. For example, V8PRIxPTR was set incorrectly on Windows 64-bit before this change since macros.h assumed that checking for V8_CC_MSVC is enough to find LLP64 systems, but V8_CC_MSVC wasn't set for clang. Most other existing checks for V8_CC_MSVC should be taken for clang-cl too (and for the remaining ones, clang-cl is happy with either code path). Likewise, V8_IMMEDIATE_CRASH is currently set to a suboptimal value with clang since __builtin_trap() is only used if V8_CC_GNU is set. Including clang in the gcc and cl macros is also what chromium does. BUG=chromium:82385 LOG=y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M include/v8config.h View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
Useful cs links: https://code.google.com/p/chromium/codesearch#chromium/src/v8/include/v8config.h&q=v8_cc_clang&sq=package:chromium&type=cs&l=196 https://code.google.com/p/chromium/codesearch#search/&q=v8_cc_gnu&sq=package:chromium&type=cs https://code.google.com/p/chromium/codesearch#search/&q=v8_cc_msvc&sq=package:chromium&type=cs I think getting rid of the whole __clang__ block ...
6 years ago (2014-12-01 20:07:23 UTC) #2
Benedikt Meurer
Feel free to come up with a patch, but please try to do the changes ...
6 years ago (2014-12-02 04:53:00 UTC) #3
Benedikt Meurer
Argh, sorry, commenting on wrong CL, although that also applies here... :-) LGTM
6 years ago (2014-12-02 04:54:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757553004/1
6 years ago (2014-12-02 04:54:54 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-02 05:23:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698