Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: include/v8config.h

Issue 757553004: Set V8_CC_GNU or V8_CC_MSVC for clang in gcc / cl mode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8config.h
diff --git a/include/v8config.h b/include/v8config.h
index 721ef373222d533f5730cd8d8d78bd8bdd9ec92d..d1ca22c229708a1611e065c4dbe8be10d20504ad 100644
--- a/include/v8config.h
+++ b/include/v8config.h
@@ -142,13 +142,12 @@
// -----------------------------------------------------------------------------
// Compiler detection
//
-// V8_CC_CLANG - Clang
-// V8_CC_GNU - GNU C++
+// V8_CC_GNU - GCC, or clang in gcc mode
// V8_CC_INTEL - Intel C++
// V8_CC_MINGW - Minimalist GNU for Windows
// V8_CC_MINGW32 - Minimalist GNU for Windows (mingw32)
// V8_CC_MINGW64 - Minimalist GNU for Windows (mingw-w64)
-// V8_CC_MSVC - Microsoft Visual C/C++
+// V8_CC_MSVC - Microsoft Visual C/C++, or clang in cl.exe mode
//
// C++11 feature detection
//
@@ -193,7 +192,11 @@
#if defined(__clang__)
-# define V8_CC_CLANG 1
+#if defined(__GNUC__) // Clang in gcc mode.
+# define V8_CC_GNU 1
+#elif defined(_MSC_VER) // Clang in cl mode.
+# define V8_CC_MSVC 1
+#endif
// Clang defines __alignof__ as alias for __alignof
# define V8_HAS___ALIGNOF 1
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698