Issue 757433005: Revert of Speculative fix for sticky keys overlay crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 757433005: Revert of Speculative fix for sticky keys overlay crash. (Closed)

Created:
6 years ago by Lei Zhang

Modified:
6 years ago

Reviewers:
James Cook, Tim Song

CC:
chromium-reviews, kalyank, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Speculative fix for sticky keys overlay crash. (patchset #2 id:20001 of https://codereview.chromium.org/754763005/) Reason for revert: StickyKeysBrowserTest leaking memory. Original issue's description: > Speculative fix for sticky keys overlay crash. > > The new test case reproduces the same stack trace as in the bug, so it's very > probable that this case is causing the crash. > > BUG=435600 > > Committed: https://crrev.com/9391c0e45bc3ae50008d0aebf11437550e7f38c6 > Cr-Commit-Position: refs/heads/master@{#306504} TBR=jamescook@chromium.org,tengs@chromium.org NOTREECHECKS=true NOTRY=true BUG=435600 Committed: https://crrev.com/e94ef4a31d0591d11421fa34065d3bc0dcd1302a Cr-Commit-Position: refs/heads/master@{#306529}

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -40 lines)			Patch
M	ash/sticky_keys/sticky_keys_overlay.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	ash/sticky_keys/sticky_keys_overlay.cc	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	ash/sticky_keys/sticky_keys_overlay_unittest.cc	View	2 chunks	+5 lines, -23 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757433005/1

6 years ago (2014-12-03 02:16:43 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-03 02:18:47 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e94ef4a31d0591d11421fa34065d3bc0dcd1302a
Cr-Commit-Position: refs/heads/master@{#306529}