Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2939)

Unified Diff: ash/sticky_keys/sticky_keys_overlay.h

Issue 757433005: Revert of Speculative fix for sticky keys overlay crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/sticky_keys/sticky_keys_overlay.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/sticky_keys/sticky_keys_overlay.h
diff --git a/ash/sticky_keys/sticky_keys_overlay.h b/ash/sticky_keys/sticky_keys_overlay.h
index 3ab234645f6f91a3518bb9562a84c42b8df56dd0..63917941a4c4bfe872d9b88ca35efa0bc5f69513 100644
--- a/ash/sticky_keys/sticky_keys_overlay.h
+++ b/ash/sticky_keys/sticky_keys_overlay.h
@@ -51,10 +51,6 @@
// animating, the returned value is the target of the animation.
bool is_visible() { return is_visible_; }
- // Returns the underlying views::Widget for testing purposes. The returned
- // widget is owned by StickyKeysOverlay.
- views::Widget* GetWidgetForTesting();
-
private:
// Returns the current bounds of the overlay, which is based on visibility.
gfx::Rect CalculateOverlayBounds();
@@ -66,7 +62,7 @@
bool is_visible_;
scoped_ptr<views::Widget> overlay_widget_;
- // The |overlay_view_| will be owned by |overlay_widget_|.
+ // Ownership of |overlay_view_| is passed to the view heirarchy.
StickyKeysOverlayView* overlay_view_;
gfx::Size widget_size_;
};
« no previous file with comments | « no previous file | ash/sticky_keys/sticky_keys_overlay.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698