Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: ui/base/BUILD.gn

Issue 757433002: ui/base: Remove ui_unittests target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/test/run_all_unittests.cc » ('j') | ui/base/ui_base_tests_bundle.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index 0143c06f091608c28d6c30525767cbd1dc641e21..a90236af07c4b025068d883683efa8d210147382 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -714,14 +714,8 @@ if (is_android) {
# TODO(GYP): Make this work on Android and reenable it.
if (!is_android) {
-# TODO(tfarina): Rename this target to ui_base_unittests.
-# In order to do this we will need to keep this target, add a dummy
-# ui_base_unittests target that just points to ui_unittests, change
-# buildbot code to reference the new 'ui_base_unittests' target.
-# After buildbot is updated, we can make the changes in Chromium and
-# remove 'ui_unittests' target. crbug.com/331829
-# GYP version: ui/base/ui_base_tests.gyp:ui_unittests
-test("ui_unittests") {
+# GYP version: ui/base/ui_base_tests.gyp:ui_base_unittests
+test("ui_base_unittests") {
sources = [
"l10n/l10n_util_mac_unittest.mm",
"l10n/l10n_util_unittest.cc",
@@ -815,7 +809,7 @@ test("ui_unittests") {
]
if (is_ios) {
- # TODO(GYP) lots of iOS-only steps for ui_unittests
+ # TODO(GYP) lots of iOS-only steps for ui_base_unittests
}
if (is_win) {
@@ -885,7 +879,7 @@ test("ui_unittests") {
deps += [
"//third_party/mozilla",
- #'ui_unittests_bundle', TODO(GYP)
+ #'ui_base_tests_bundle', TODO(GYP)
]
}
@@ -911,4 +905,4 @@ test("ui_unittests") {
}
}
}
-# TODO(GYP) Mac (ui_unittest_bundle) and Android (ui_unittests_apk).
+# TODO(GYP) Mac (ui_base_tests_bundle) and Android (ui_base_unittests_apk).
« no previous file with comments | « no previous file | ui/base/test/run_all_unittests.cc » ('j') | ui/base/ui_base_tests_bundle.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698