Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: ui/base/BUILD.gn

Issue 757433002: ui/base: Remove ui_unittests target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/base/test/run_all_unittests.cc » ('j') | ui/base/ui_base_tests_bundle.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 6
7 if (is_android) { 7 if (is_android) {
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 import("//build/config/android/rules.gni") 9 import("//build/config/android/rules.gni")
10 } 10 }
(...skipping 696 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 "../android/java/src/org/chromium/ui/base/TouchDevice.java", 707 "../android/java/src/org/chromium/ui/base/TouchDevice.java",
708 "../android/java/src/org/chromium/ui/base/ViewAndroid.java", 708 "../android/java/src/org/chromium/ui/base/ViewAndroid.java",
709 "../android/java/src/org/chromium/ui/base/WindowAndroid.java", 709 "../android/java/src/org/chromium/ui/base/WindowAndroid.java",
710 ] 710 ]
711 jni_package = "base" 711 jni_package = "base"
712 } 712 }
713 } 713 }
714 714
715 # TODO(GYP): Make this work on Android and reenable it. 715 # TODO(GYP): Make this work on Android and reenable it.
716 if (!is_android) { 716 if (!is_android) {
717 # TODO(tfarina): Rename this target to ui_base_unittests. 717 # GYP version: ui/base/ui_base_tests.gyp:ui_base_unittests
718 # In order to do this we will need to keep this target, add a dummy 718 test("ui_base_unittests") {
719 # ui_base_unittests target that just points to ui_unittests, change
720 # buildbot code to reference the new 'ui_base_unittests' target.
721 # After buildbot is updated, we can make the changes in Chromium and
722 # remove 'ui_unittests' target. crbug.com/331829
723 # GYP version: ui/base/ui_base_tests.gyp:ui_unittests
724 test("ui_unittests") {
725 sources = [ 719 sources = [
726 "l10n/l10n_util_mac_unittest.mm", 720 "l10n/l10n_util_mac_unittest.mm",
727 "l10n/l10n_util_unittest.cc", 721 "l10n/l10n_util_unittest.cc",
728 "l10n/l10n_util_win_unittest.cc", 722 "l10n/l10n_util_win_unittest.cc",
729 "l10n/time_format_unittest.cc", 723 "l10n/time_format_unittest.cc",
730 "layout_unittest.cc", 724 "layout_unittest.cc",
731 "models/tree_node_iterator_unittest.cc", 725 "models/tree_node_iterator_unittest.cc",
732 "resource/data_pack_literal.cc", 726 "resource/data_pack_literal.cc",
733 "resource/data_pack_unittest.cc", 727 "resource/data_pack_unittest.cc",
734 "resource/resource_bundle_unittest.cc", 728 "resource/resource_bundle_unittest.cc",
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 "//ui/events:events_base", 802 "//ui/events:events_base",
809 "//ui/events:test_support", 803 "//ui/events:test_support",
810 "//ui/gfx:test_support", 804 "//ui/gfx:test_support",
811 "//ui/resources", 805 "//ui/resources",
812 "//ui/resources:ui_test_pak", 806 "//ui/resources:ui_test_pak",
813 "//ui/strings", 807 "//ui/strings",
814 "//url", 808 "//url",
815 ] 809 ]
816 810
817 if (is_ios) { 811 if (is_ios) {
818 # TODO(GYP) lots of iOS-only steps for ui_unittests 812 # TODO(GYP) lots of iOS-only steps for ui_base_unittests
819 } 813 }
820 814
821 if (is_win) { 815 if (is_win) {
822 sources += [ 816 sources += [
823 "dragdrop/os_exchange_data_win_unittest.cc", 817 "dragdrop/os_exchange_data_win_unittest.cc",
824 "win/hwnd_subclass_unittest.cc", 818 "win/hwnd_subclass_unittest.cc",
825 "win/open_file_name_win_unittest.cc", 819 "win/open_file_name_win_unittest.cc",
826 ] 820 ]
827 821
828 ldflags = [ 822 ldflags = [
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
878 } 872 }
879 873
880 if (is_mac) { 874 if (is_mac) {
881 sources -= [ 875 sources -= [
882 "dragdrop/os_exchange_data_provider_aurax11_unittest.cc", 876 "dragdrop/os_exchange_data_provider_aurax11_unittest.cc",
883 "x/selection_requestor_unittest.cc", 877 "x/selection_requestor_unittest.cc",
884 ] 878 ]
885 879
886 deps += [ 880 deps += [
887 "//third_party/mozilla", 881 "//third_party/mozilla",
888 #'ui_unittests_bundle', TODO(GYP) 882 #'ui_base_tests_bundle', TODO(GYP)
889 ] 883 ]
890 } 884 }
891 885
892 if (use_aura || toolkit_views) { 886 if (use_aura || toolkit_views) {
893 sources += [ 887 sources += [
894 "dragdrop/os_exchange_data_unittest.cc" 888 "dragdrop/os_exchange_data_unittest.cc"
895 ] 889 ]
896 890
897 deps += [ 891 deps += [
898 "//ui/events", 892 "//ui/events",
899 "//ui/events/platform", 893 "//ui/events/platform",
900 ] 894 ]
901 } 895 }
902 896
903 if (is_chromeos) { 897 if (is_chromeos) {
904 sources -= [ 898 sources -= [
905 "dragdrop/os_exchange_data_provider_aurax11_unittest.cc", 899 "dragdrop/os_exchange_data_provider_aurax11_unittest.cc",
906 "x/selection_requestor_unittest.cc", 900 "x/selection_requestor_unittest.cc",
907 ] 901 ]
908 deps += [ 902 deps += [
909 "//chromeos", 903 "//chromeos",
910 ] 904 ]
911 } 905 }
912 } 906 }
913 } 907 }
914 # TODO(GYP) Mac (ui_unittest_bundle) and Android (ui_unittests_apk). 908 # TODO(GYP) Mac (ui_base_tests_bundle) and Android (ui_base_unittests_apk).
OLDNEW
« no previous file with comments | « no previous file | ui/base/test/run_all_unittests.cc » ('j') | ui/base/ui_base_tests_bundle.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698