ui/base: Remove ui_unittests target.

ui/base: Remove ui_unittests target.

Now that everything migrated from 'ui_unittests' target to
'ui_base_unittests', we can remove it and clean things up.

BUG=331829, 373148, 299841, 103304
TEST=
R=sky@chromium.org

Committed: https://crrev.com/83a52369cf414cec1bae727ab39f12f439e87678
Cr-Commit-Position: refs/heads/master@{#306406}

[tfarina, 2014-11-23 16:52:39]

Scott -> everything

Nico, Trent -> question below about the Mac bundle stuff.

https://codereview.chromium.org/757433002/diff/1/ui/base/ui_base_tests_bundle...
File ui/base/ui_base_tests_bundle.gypi (right):

https://codereview.chromium.org/757433002/diff/1/ui/base/ui_base_tests_bundle...
ui/base/ui_base_tests_bundle.gypi:8: 'product_name': 'ui_unittests Framework',
Nico, Trent, is it fine to change this name in this CL? I was planning to rename
it in a follow up, as I don't know if it is fine or not. Not sure how it will
effect iOS/Mac build.

[tapted, 2014-11-23 22:12:31]

tapted@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2014-11-23 22:12:32]

https://codereview.chromium.org/757433002/diff/1/ui/base/ui_base_tests_bundle...
File ui/base/ui_base_tests_bundle.gypi (right):

https://codereview.chromium.org/757433002/diff/1/ui/base/ui_base_tests_bundle...
ui/base/ui_base_tests_bundle.gypi:8: 'product_name': 'ui_unittests Framework',
On 2014/11/23 16:52:39, tfarina wrote:
> Nico, Trent, is it fine to change this name in this CL? I was planning to
rename
> it in a follow up, as I don't know if it is fine or not. Not sure how it will
> effect iOS/Mac build.

So long as the string literal in ui/base/test/run_all_unittests.cc is updated at
the same time, nothing comes to mind that might explode.

I'd also consider not renaming it. It doesn't have a dependency on
ui_base_unittests, and lots of test targets that are not "ui_base" use
ui_test.pak. This Framework bundle is just a wrapper around ui_test.pak. If,
say, app_list_unittests wanted a (semi)proper app bundle, it could re-use this.

So, not renaming is probably my preference, but I don't have strong feelings
about it.

[tfarina, 2014-11-24 17:23:44]

https://codereview.chromium.org/757433002/diff/1/ui/base/ui_base_tests_bundle...
File ui/base/ui_base_tests_bundle.gypi (right):

https://codereview.chromium.org/757433002/diff/1/ui/base/ui_base_tests_bundle...
ui/base/ui_base_tests_bundle.gypi:8: 'product_name': 'ui_unittests Framework',
On 2014/11/23 22:12:32, tapted wrote:
> On 2014/11/23 16:52:39, tfarina wrote:
> > Nico, Trent, is it fine to change this name in this CL? I was planning to
> rename
> > it in a follow up, as I don't know if it is fine or not. Not sure how it
will
> > effect iOS/Mac build.
> 
> So long as the string literal in ui/base/test/run_all_unittests.cc is updated
at
> the same time, nothing comes to mind that might explode.
> 
> I'd also consider not renaming it. It doesn't have a dependency on
> ui_base_unittests, and lots of test targets that are not "ui_base" use
> ui_test.pak. This Framework bundle is just a wrapper around ui_test.pak. If,
> say, app_list_unittests wanted a (semi)proper app bundle, it could re-use
this.
> 
> So, not renaming is probably my preference, but I don't have strong feelings
> about it.
Thanks Trent. I will let that for a follow up CL then.

[tfarina, 2014-11-25 12:59:21]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-11-25 12:59:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757433002/1

[commit-bot: I haz the power, 2014-11-25 12:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-25 12:59:58]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tfarina, 2014-11-26 02:05:33]

tfarina@chromium.org changed reviewers:
- tapted@chromium.org

[tfarina, 2014-12-02 14:50:19]

Scott, ping?

[sky, 2014-12-02 16:19:23]

LGTM

[tfarina, 2014-12-02 16:35:53]

On 2014/12/02 16:19:23, sky wrote:
> LGTM

Thanks :)

[tfarina, 2014-12-02 16:36:53]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-12-02 16:37:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757433002/1

[commit-bot: I haz the power, 2014-12-02 17:14:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-02 17:16:47]

Patchset 1 (id:??) landed as
https://crrev.com/83a52369cf414cec1bae727ab39f12f439e87678
Cr-Commit-Position: refs/heads/master@{#306406}