Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 757233004: Fixing bugs introduced by new presubmit changes. (Closed)

Created:
6 years ago by gayane -on leave until 09-2017
Modified:
6 years ago
CC:
chromium-reviews, arv+watch_chromium.org, michaelpg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing bugs introduced by new presubmit changes Fixing issues introduced by https://codereview.chromium.org/719463003/. - Fixing the constant suffix in case of boolean action - comment fix for mocks. BUG=439328 TBR=phajdan.jr@chromium.org, brettw@chromium.org Committed: https://crrev.com/860db5c33134662dd2a27c8c295df8d55fdbadea Cr-Commit-Position: refs/heads/master@{#307030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M PRESUBMIT_test_mocks.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/PRESUBMIT_test.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757233004/1
6 years ago (2014-12-05 05:58:33 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-05 05:58:34 UTC) #4
gayane -on leave until 09-2017
Please review my fixes. There is one more issue that I am looking at now. ...
6 years ago (2014-12-05 06:01:56 UTC) #6
gayane -on leave until 09-2017
CC-ing michaelpg
6 years ago (2014-12-05 06:04:44 UTC) #7
Alexei Svitkine (slow)
lgtm, I think you can TBR owners for this
6 years ago (2014-12-05 15:28:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/757233004/1
6 years ago (2014-12-05 15:42:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 16:16:55 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-05 16:18:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/860db5c33134662dd2a27c8c295df8d55fdbadea
Cr-Commit-Position: refs/heads/master@{#307030}

Powered by Google App Engine
This is Rietveld 408576698