chrome/browser/resources/PRESUBMIT.py - Issue 757233004: Fixing bugs introduced by new presubmit changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 757233004: Fixing bugs introduced by new presubmit changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/PRESUBMIT.py

diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py

index 0aa7b9671fe518e3a8c2a139a3317fd711ff70a5..e22e2a09f825b0c5cdd9d2dcb3caf72bc5bd38e8 100644

--- a/chrome/browser/resources/PRESUBMIT.py

+++ b/chrome/browser/resources/PRESUBMIT.py

@@ -59,8 +59,8 @@ def IsActionPresent(current_actions, metric_name, is_boolean):

action = 'name="{0}"'.format(metric_name)

return action in current_actions

- action_disabled = 'name="{0}_Disabled"'.format(metric_name)

- action_enabled = 'name="{0}_Enabled"'.format(metric_name)

+ action_disabled = 'name="{0}_Disable"'.format(metric_name)

+ action_enabled = 'name="{0}_Enable"'.format(metric_name)

return (action_disabled in current_actions and

action_enabled in current_actions)

« no previous file with comments | « PRESUBMIT_test_mocks.py ('k') | chrome/browser/resources/PRESUBMIT_test.py » ('j') | no next file with comments »