Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: media/audio/virtual_audio_output_stream.cc

Issue 756733003: Fix latency plumbing in media::VirtualAudio[Input|Output]Stream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/virtual_audio_input_stream.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/virtual_audio_output_stream.cc
diff --git a/media/audio/virtual_audio_output_stream.cc b/media/audio/virtual_audio_output_stream.cc
index 016c2f331b32e13ec1db8acab47d615405df6949..29e3804fe21daa3d6488b8aa80b5463cbc796db0 100644
--- a/media/audio/virtual_audio_output_stream.cc
+++ b/media/audio/virtual_audio_output_stream.cc
@@ -77,7 +77,12 @@ double VirtualAudioOutputStream::ProvideInput(AudioBus* audio_bus,
// platform.
DCHECK(callback_);
- const int frames = callback_->OnMoreData(audio_bus, 0);
+ DCHECK_GE(buffer_delay, base::TimeDelta());
+ const int64 upstream_delay_in_bytes =
+ params_.GetBytesPerSecond() * buffer_delay /
+ base::TimeDelta::FromSeconds(1);
+ const int frames = callback_->OnMoreData(
+ audio_bus, static_cast<uint32>(upstream_delay_in_bytes));
hubbe 2014/12/01 21:56:46 Is this allowed to not be a multiple of channels*b
miu 2014/12/02 00:02:44 The call to GetBytesPerSecond() ensures this, sinc
if (frames < audio_bus->frames())
audio_bus->ZeroFramesPartial(frames, audio_bus->frames() - frames);
« no previous file with comments | « media/audio/virtual_audio_input_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698