Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 756733003: Fix latency plumbing in media::VirtualAudio[Input|Output]Stream. (Closed)

Created:
6 years ago by miu
Modified:
6 years ago
Reviewers:
hubbe
CC:
chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix latency plumbing in media::VirtualAudio[Input|Output]Stream. Adds accounting for the buffer offsets introduced by the graph of media::AudioConverters. Also, fixed the latency value being emitted by VirtualAudioInputStream (should be zero, not the audio_bus duration). This change, in combination with https://codereview.chromium.org/759383003, results in CastV2PerfomanceTest's av_sync metric becoming 0.359 ms (down from 24.7 ms). Committed: https://crrev.com/06e0b571a9cbb948564ea986f3dea0b9d8c87492 Cr-Commit-Position: refs/heads/master@{#306302}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M media/audio/virtual_audio_input_stream.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M media/audio/virtual_audio_output_stream.cc View 1 chunk +6 lines, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
miu
hubbe: More awesome to improve AV sync. PTAL.
6 years ago (2014-11-27 02:15:33 UTC) #2
hubbe
LGTM Unfortunately I'm not very familiar with the frameworks, so depending on your comfort level, ...
6 years ago (2014-12-01 21:56:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756733003/1
6 years ago (2014-12-02 00:02:06 UTC) #5
miu
https://codereview.chromium.org/756733003/diff/1/media/audio/virtual_audio_output_stream.cc File media/audio/virtual_audio_output_stream.cc (right): https://codereview.chromium.org/756733003/diff/1/media/audio/virtual_audio_output_stream.cc#newcode85 media/audio/virtual_audio_output_stream.cc:85: audio_bus, static_cast<uint32>(upstream_delay_in_bytes)); On 2014/12/01 21:56:46, hubbe wrote: > Is ...
6 years ago (2014-12-02 00:02:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-02 00:04:48 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-02 00:05:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06e0b571a9cbb948564ea986f3dea0b9d8c87492
Cr-Commit-Position: refs/heads/master@{#306302}

Powered by Google App Engine
This is Rietveld 408576698