Issue 756703002: disable link disambiguation by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 756703002: disable link disambiguation by default (Closed)

Created:
6 years ago by luken

Modified:
6 years ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, asvitkine+watch_chromium.org, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171_62

Project:
chromium

Visibility:
Public.

disable link disambiguation by default flips the logic on the --disable-link-disambiguation flag to --enable-link-disambiguation with the default value of false everywhere but Android. Also fixes the broken logic to copy the value to the renderer process. BUG=433007, 428163 Review URL: https://codereview.chromium.org/746403003 Cr-Commit-Position: refs/heads/master@{#305473} (cherry picked from commit 30ef562dd08275301b4a8260b650d24a8f148fbb) Committed: https://chromium.googlesource.com/chromium/src/+/6bc002f746847f2e0b18d46e92e81822225ba7f4

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -17 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/ui_base_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/ui_base_switches.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	ui/base/ui_base_switches_util.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 1 (0 generated)

luken

6 years ago (2014-11-24 20:15:14 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6bc002f746847f2e0b18d46e92e81822225ba7f4.