disable link disambiguation by default

disable link disambiguation by default

flips the logic on the --disable-link-disambiguation flag to
--enable-link-disambiguation with the default value of false everywhere
but Android. Also fixes the broken logic to copy the value to the
renderer process.

BUG=433007, 428163
Committed: https://crrev.com/30ef562dd08275301b4a8260b650d24a8f148fbb
Cr-Commit-Position: refs/heads/master@{#305473}

[luken, 2014-11-24 17:49:15]

luken@chromium.org changed reviewers:
+ cpu@chromium.org

[luken, 2014-11-24 17:50:15]

luken@chromium.org changed reviewers:
+ jar@chromium.org

[luken, 2014-11-24 17:50:16]

jar: histogram.xml
cpu: everything else
Thank you

[jar (doing other things), 2014-11-24 17:54:35]

jar@chromium.org changed reviewers:
+ asvitkine@chromium.org

[jar (doing other things), 2014-11-24 17:54:36]

+asvitkine for histograms

[Alexei Svitkine (slow), 2014-11-24 17:57:12]

https://codereview.chromium.org/746403003/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/746403003/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:48620: -  <int value="929462705"
label="disable-link-disambiguation-popup"/>
Please keep the existing value, so data from older versions can still be
decoded.

[jdduke (slow), 2014-11-24 18:00:42]

jdduke@chromium.org changed reviewers:
+ jdduke@chromium.org

[jdduke (slow), 2014-11-24 18:00:47]

https://codereview.chromium.org/746403003/diff/1/ui/base/ui_base_switches_uti...
File ui/base/ui_base_switches_util.cc (right):

https://codereview.chromium.org/746403003/diff/1/ui/base/ui_base_switches_uti...
ui/base/ui_base_switches_util.cc:13: if
(CommandLine::ForCurrentProcess()->HasSwitch(
Nit: Can you move this check to the #else branch?

[luken, 2014-11-24 18:12:04]

https://codereview.chromium.org/746403003/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/746403003/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:48620: -  <int value="929462705"
label="disable-link-disambiguation-popup"/>
On 2014/11/24 17:57:12, Alexei Svitkine wrote:
> Please keep the existing value, so data from older versions can still be
> decoded.

Done.

https://codereview.chromium.org/746403003/diff/1/ui/base/ui_base_switches_uti...
File ui/base/ui_base_switches_util.cc (right):

https://codereview.chromium.org/746403003/diff/1/ui/base/ui_base_switches_uti...
ui/base/ui_base_switches_util.cc:13: if
(CommandLine::ForCurrentProcess()->HasSwitch(
On 2014/11/24 18:00:46, jdduke wrote:
> Nit: Can you move this check to the #else branch?

Done.

[cpu_(ooo_6.6-7.5), 2014-11-24 18:49:35]

lgtm

[luken, 2014-11-24 18:50:16]

The CQ bit was checked by luken@chromium.org

[cpu_(ooo_6.6-7.5), 2014-11-24 18:50:31]

The CQ bit was checked by cpu@chromium.org

[commit-bot: I haz the power, 2014-11-24 18:51:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/746403003/20001

[Alexei Svitkine (slow), 2014-11-24 18:51:47]

LGTM

[commit-bot: I haz the power, 2014-11-24 19:38:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-24 19:38:56]

Patchset 2 (id:??) landed as
https://crrev.com/30ef562dd08275301b4a8260b650d24a8f148fbb
Cr-Commit-Position: refs/heads/master@{#305473}