Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 756653005: Change the flag which enables OOP PDF to an enable/disable flag (Closed)

Created:
6 years ago by raymes
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change the flag which enables OOP PDF to an enable/disable flag This leaves the default as disabled. BUG=303491 Committed: https://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97 Cr-Commit-Position: refs/heads/master@{#305738}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/pdf_extension_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 4 chunks +3 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 4 chunks +17 lines, -3 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
raymes
6 years ago (2014-11-25 03:46:20 UTC) #2
Sam McNally
https://codereview.chromium.org/756653005/diff/1/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): https://codereview.chromium.org/756653005/diff/1/chrome/browser/chrome_content_browser_client.cc#newcode1382 chrome/browser/chrome_content_browser_client.cc:1382: switches::kEnableOutOfProcessPdf, What about kDisableOutOfProcessPdf?
6 years ago (2014-11-25 04:14:36 UTC) #3
raymes
+OWNERS thestig@ for chrome/* isherman@ for histograms.xml
6 years ago (2014-11-25 11:45:16 UTC) #5
Ilya Sherman
histograms.xml lgtm
6 years ago (2014-11-25 21:05:09 UTC) #6
Lei Zhang
lgtm https://codereview.chromium.org/756653005/diff/20001/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/756653005/diff/20001/chrome/common/chrome_switches.cc#newcode887 chrome/common/chrome_switches.cc:887: // Enable or disable the out of process ...
6 years ago (2014-11-25 22:22:30 UTC) #7
raymes
Thanks! https://codereview.chromium.org/756653005/diff/20001/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/756653005/diff/20001/chrome/common/chrome_switches.cc#newcode887 chrome/common/chrome_switches.cc:887: // Enable or disable the out of process ...
6 years ago (2014-11-25 22:36:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756653005/40001
6 years ago (2014-11-25 22:37:43 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-11-26 00:49:29 UTC) #11
commit-bot: I haz the power
6 years ago (2014-11-26 00:50:17 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97
Cr-Commit-Position: refs/heads/master@{#305738}

Powered by Google App Engine
This is Rietveld 408576698