Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/chrome_browser_main_win.cc

Issue 756653005: Change the flag which enables OOP PDF to an enable/disable flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main_win.h" 5 #include "chrome/browser/chrome_browser_main_win.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shellapi.h> 8 #include <shellapi.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 // force the PDF pepper plugin to run out of process. This is because the 243 // force the PDF pepper plugin to run out of process. This is because the
244 // PDF plugin uses GDI for text rendering which does not work in the 244 // PDF plugin uses GDI for text rendering which does not work in the
245 // Win32K lockdown mode. Running it out of process ensures that the process 245 // Win32K lockdown mode. Running it out of process ensures that the process
246 // launched for the plugin does not have the Win32K lockdown mode enabled. 246 // launched for the plugin does not have the Win32K lockdown mode enabled.
247 // TODO(ananta) 247 // TODO(ananta)
248 // Revisit this when the pdf plugin uses skia and stops using GDI. 248 // Revisit this when the pdf plugin uses skia and stops using GDI.
249 if (CommandLine::ForCurrentProcess()->HasSwitch( 249 if (CommandLine::ForCurrentProcess()->HasSwitch(
250 switches::kEnableWin32kRendererLockDown) && 250 switches::kEnableWin32kRendererLockDown) &&
251 base::win::GetVersion() >= base::win::VERSION_WIN8) { 251 base::win::GetVersion() >= base::win::VERSION_WIN8) {
252 CommandLine::ForCurrentProcess()->AppendSwitch( 252 CommandLine::ForCurrentProcess()->AppendSwitch(
253 switches::kOutOfProcessPdf); 253 switches::kEnableOutOfProcessPdf);
254 } 254 }
255 return rv; 255 return rv;
256 } 256 }
257 257
258 void ChromeBrowserMainPartsWin::ShowMissingLocaleMessageBox() { 258 void ChromeBrowserMainPartsWin::ShowMissingLocaleMessageBox() {
259 ui::MessageBox(NULL, 259 ui::MessageBox(NULL,
260 base::ASCIIToUTF16(chrome_browser::kMissingLocaleDataMessage), 260 base::ASCIIToUTF16(chrome_browser::kMissingLocaleDataMessage),
261 base::ASCIIToUTF16(chrome_browser::kMissingLocaleDataTitle), 261 base::ASCIIToUTF16(chrome_browser::kMissingLocaleDataTitle),
262 MB_OK | MB_ICONERROR | MB_TOPMOST); 262 MB_OK | MB_ICONERROR | MB_TOPMOST);
263 } 263 }
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 if (resource_id) 484 if (resource_id)
485 return l10n_util::GetStringUTF16(resource_id); 485 return l10n_util::GetStringUTF16(resource_id);
486 return base::string16(); 486 return base::string16();
487 } 487 }
488 488
489 // static 489 // static
490 void ChromeBrowserMainPartsWin::SetupInstallerUtilStrings() { 490 void ChromeBrowserMainPartsWin::SetupInstallerUtilStrings() {
491 CR_DEFINE_STATIC_LOCAL(TranslationDelegate, delegate, ()); 491 CR_DEFINE_STATIC_LOCAL(TranslationDelegate, delegate, ());
492 installer::SetTranslationDelegate(&delegate); 492 installer::SetTranslationDelegate(&delegate);
493 } 493 }
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698