Issue 756653004: Add Logging{Read,Write}FD() and CheckedCloseFD()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 756653004: Add Logging{Read,Write}FD() and CheckedCloseFD() (Closed)

Created:
6 years ago by Mark Mentovai

Modified:
6 years ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -8 lines)			Patch
	M	util/file/fd_io.h	View		4 chunks	+35 lines, -0 lines	0 comments	Download
	M	util/file/fd_io.cc	View		2 chunks	+30 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

I needed LoggingWriteFD() for ChildPortHandshake. CheckedWriteFD() would not work, because the child might close its ...

6 years ago (2014-11-24 20:25:07 UTC) #2

Mark Mentovai

6 years ago (2014-11-24 20:49:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
af1c7eb098ce702c414d7a72ce72a62fd98bbd9b (presubmit successful).