Add Logging{Read,Write}FD() and CheckedCloseFD()

util/file/fd_io.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 56 matching lines @@
 namespace crashpad {
 
 ssize_t ReadFD(int fd, void* buffer, size_t size) {
   return ReadOrWrite<ReadTraits>(fd, buffer, size);
 }
 
 ssize_t WriteFD(int fd, const void* buffer, size_t size) {
   return ReadOrWrite<WriteTraits>(fd, buffer, size);
 }
 
-void CheckedReadFD(int fd, void* buffer, size_t size) {
+bool LoggingReadFD(int fd, void* buffer, size_t size) {
   ssize_t expect = base::checked_cast<ssize_t>(size);
   ssize_t rv = ReadFD(fd, buffer, size);
   if (rv < 0) {
-    PCHECK(rv == expect) << "read";
-  } else {
-    CHECK_EQ(rv, expect) << "read";
+    PLOG(ERROR) << "read";
+    return false;
   }
+  if (rv != expect) {
+    LOG(ERROR) << "read: expected " << expect << ", observed " << rv;
+    return false;
+  }
+
+  return true;
+}
+
+bool LoggingWriteFD(int fd, const void* buffer, size_t size) {
+  ssize_t expect = base::checked_cast<ssize_t>(size);
+  ssize_t rv = WriteFD(fd, buffer, size);
+  if (rv < 0) {
+    PLOG(ERROR) << "write";
+    return false;
+  }
+  if (rv != expect) {
+    LOG(ERROR) << "write: expected " << expect << ", observed " << rv;
+    return false;
+  }
+
+  return true;
+}
+
+void CheckedReadFD(int fd, void* buffer, size_t size) {
+  CHECK(LoggingReadFD(fd, buffer, size));
 }
 
 void CheckedWriteFD(int fd, const void* buffer, size_t size) {
-  ssize_t expect = base::checked_cast<ssize_t>(size);
-  ssize_t rv = WriteFD(fd, buffer, size);
-  if (rv < 0) {
-    PCHECK(rv == expect) << "write";
-  } else {
-    CHECK_EQ(rv, expect) << "write";
-  }
+  CHECK(LoggingWriteFD(fd, buffer, size));
 }
 
 void CheckedReadFDAtEOF(int fd) {
   char c;
   ssize_t rv = ReadFD(fd, &c, 1);
   if (rv < 0) {
     PCHECK(rv == 0) << "read";
   } else {
     CHECK_EQ(rv, 0) << "read";
   }
 }
 
 bool LoggingCloseFD(int fd) {
   int rv = IGNORE_EINTR(close(fd));
   PLOG_IF(ERROR, rv != 0) << "close";
   return rv == 0;
 }
 
+void CheckedCloseFD(int fd) {
+  CHECK(LoggingCloseFD(fd));
+}
+
 }  // namespace crashpad