Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 75663004: net: boost AES-GCM ciphers if the machine has AES-NI. (Closed)

Created:
5 years, 7 months ago by agl
Modified:
5 years, 6 months ago
Reviewers:
Mark Mentovai, wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

net: boost AES-GCM ciphers if the machine has AES-NI. We want to use ChaCha20 based cipher suites on machines that don't have AES-NI and AES-GCM on those that do. BUG=310768

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : Remove unused variable #

Total comments: 21

Patch Set 4 : ... #

Total comments: 24

Patch Set 5 : ... #

Patch Set 6 : Merge with master #

Total comments: 3

Patch Set 7 : codereview is broken. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -1 line) Patch
base/cpu.h View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
base/cpu.cc View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
net/socket/nss_ssl_util.h View 1 2 3 4 5 6 2 chunks +10 lines, -0 lines 0 comments Download
net/socket/nss_ssl_util.cc View 1 2 3 4 5 6 4 chunks +109 lines, -1 line 0 comments Download
net/socket/ssl_client_socket_nss.cc View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
net/third_party/nss/README.chromium View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
net/third_party/nss/patches/applypatches.sh View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
net/third_party/nss/patches/cipherorder.patch View 1 2 3 1 chunk +104 lines, -0 lines 0 comments Download
net/third_party/nss/ssl/ssl.h View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
net/third_party/nss/ssl/ssl3con.c View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
net/third_party/nss/ssl/sslimpl.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
net/third_party/nss/ssl/sslsock.c View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
agl
5 years, 7 months ago (2013-11-18 23:25:16 UTC) #1
wtc
Patch set 3 LGTM. https://codereview.chromium.org/75663004/diff/30002/base/cpu.h File base/cpu.h (right): https://codereview.chromium.org/75663004/diff/30002/base/cpu.h#newcode28 base/cpu.h:28: AVX, Do we need an ...
5 years, 7 months ago (2013-11-19 23:00:44 UTC) #2
agl
https://codereview.chromium.org/75663004/diff/30002/base/cpu.h File base/cpu.h (right): https://codereview.chromium.org/75663004/diff/30002/base/cpu.h#newcode28 base/cpu.h:28: AVX, On 2013/11/19 23:00:44, wtc wrote: > Do we ...
5 years, 7 months ago (2013-11-20 18:21:06 UTC) #3
wtc
Patch set 4 LGTM. Please make the model socket change in a separate CL, to ...
5 years, 7 months ago (2013-11-22 01:14:15 UTC) #4
agl
https://codereview.chromium.org/75663004/diff/280001/net/socket/nss_ssl_util.cc File net/socket/nss_ssl_util.cc (right): https://codereview.chromium.org/75663004/diff/280001/net/socket/nss_ssl_util.cc#newcode53 net/socket/nss_ssl_util.cc:53: } On 2013/11/22 01:14:16, wtc wrote: > > I ...
5 years, 7 months ago (2013-11-22 17:53:48 UTC) #5
agl
+ajwong for base/ OWNERS.
5 years, 7 months ago (2013-11-22 19:30:51 UTC) #6
wtc
Patch set 6 LGTM. https://codereview.chromium.org/75663004/diff/520001/net/socket/nss_ssl_util.cc File net/socket/nss_ssl_util.cc (right): https://codereview.chromium.org/75663004/diff/520001/net/socket/nss_ssl_util.cc#newcode86 net/socket/nss_ssl_util.cc:86: : num_ciphers_(0) { Nit: the ...
5 years, 7 months ago (2013-11-23 01:02:07 UTC) #7
agl
+mark for base/ OWNERS.
5 years, 6 months ago (2013-11-25 18:37:12 UTC) #8
Mark Mentovai
LGTM for base OWNERS approval.
5 years, 6 months ago (2013-11-25 18:53:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/75663004/520001
5 years, 6 months ago (2013-11-25 19:07:00 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=192887
5 years, 6 months ago (2013-11-25 19:23:50 UTC) #11
wtc
https://codereview.chromium.org/75663004/diff/520001/net/socket/nss_ssl_util.h File net/socket/nss_ssl_util.h (right): https://codereview.chromium.org/75663004/diff/520001/net/socket/nss_ssl_util.h#newcode37 net/socket/nss_ssl_util.h:37: const uint16* GetNSSCipherOrder(size_t* out_length); Compilation failed because uint16 is ...
5 years, 6 months ago (2013-11-27 14:50:12 UTC) #12
agl
5 years, 6 months ago (2013-11-27 16:08:32 UTC) #13
https://codereview.chromium.org/75663004/diff/520001/net/socket/nss_ssl_util.h
File net/socket/nss_ssl_util.h (right):

https://codereview.chromium.org/75663004/diff/520001/net/socket/nss_ssl_util....
net/socket/nss_ssl_util.h:37: const uint16* GetNSSCipherOrder(size_t*
out_length);
On 2013/11/27 14:50:13, wtc wrote:
> 
> Compilation failed because uint16 is not defined.
> 
> We need to either switch to PRUint16 or include "base/basictypes.h".

Thanks. I had missed this CQ failure.

codereview broke and I cannot upload changes to this issue any longer so I've
moved it to https://codereview.chromium.org/91913002/

Powered by Google App Engine
This is Rietveld 408576698