Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issue 756363003: Revert of Sync starting language and input method preferences (Closed)

Created:
6 years ago by spang
Modified:
6 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, yukishiino+watch_chromium.org, aboxhall+watch_chromium.org, arv+watch_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, yusukes+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, Seigo Nonaka, Nikita (slow)
Visibility:
Public.

Description

Revert of Sync starting language and input method preferences (patchset #14 id:360001 of https://codereview.chromium.org/312023002/) Reason for revert: Causes NULL pointer dereference. #0 chromeos::input_method::(anonymous namespace)::CheckAndResolveLocales (languages=0x0) at ../../chrome/browser/chromeos/input_method/input_method_syncer.cc:58 #1 0x00007f9466f9ddd2 in Run (this=<optimized out>) at ../../base/callback.h:396 #2 base::(anonymous namespace)::PostTaskAndReplyRelay::Run (this=0x647e3eb28c0) at ../../base/threading/post_task_and_reply_impl.cc:42 #3 0x00007f9466fa1257 in Run (this=0x7f9454cb1b10) at ../../base/callback.h:396 #4 base::SequencedWorkerPool::Inner::ThreadLoop (this=0x647e2117000, this_worker=this_worker@entry=0x647e34f5190) at ../../base/threading/sequenced_worker_pool.cc:760 #5 0x00007f9466fa199d in base::SequencedWorkerPool::Worker::Run (this=0x647e34f5190) at ../../base/threading/sequenced_worker_pool.cc:507 #6 0x00007f9466fa1d51 in base::SimpleThread::ThreadMain (this=0x647e34f5190) at ../../base/threading/simple_thread.cc:60 #7 0x00007f9466f9db30 in base::(anonymous namespace)::ThreadFunc (params=<optimized out>) at ../../base/threading/platform_thread_posix.cc:80 #8 0x00007f94654ae321 in start_thread (arg=0x7f9454cb2700) at pthread_create.c:309 #9 0x00007f94649527ed in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111 Original issue's description: > Sync starting language and input method preferences > > Users who use additional Chromebooks or who recreate their accounts have > to manually set up their preferred languages, input methods and IMEs on > each device, because only the locale (display language) syncs. > > We don't forcibly keep these settings in sync because different machines > may use different built-in or peripheral keyboards. But we can make the > set-up process smoother if we know what settings the user chose most > recently. > > This CL creates syncable of the language and input > methods preferences, so the server always has the latest changes. > > When, and only when, a user logs in and syncs for the first time on a > device, we take the local variants the user has already chosen for this > machine, and we add to them the global variants that come down from > sync. This only happens at most once. It should only be additive, not > remove any chosen settings. > > Some caveats: > * If the user makes a change to one language/input setting, sync all > three interdependent settings so the sync server's settings are > always internally consistent. > > BUG=298345 > R=nkostylev@chromium.org, yukishiino@chromium.org, hajimehoshi@chromium.org > CC=nona@chromium.org > > Committed: https://crrev.com/cceac6fae685fd86d6f347d6712886549e372231 > Cr-Commit-Position: refs/heads/master@{#306164} TBR=hajimehoshi@chromium.org,alemate@chromium.org,shuchen@chromium.org,yukishiino@chromium.org,dzhioev@chromium.org,dpolukhin@chromium.org,michaelpg@chromium.org NOTREECHECKS=true NOTRY=true BUG=298345 Committed: https://crrev.com/1a140c96c6751e8dff5ed06f2e45978fb1c806f4 Cr-Commit-Position: refs/heads/master@{#306233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1120 lines) Patch
D chrome/browser/chromeos/input_method/input_method_syncer.h View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_syncer.cc View 1 chunk +0 lines, -328 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 9 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 3 chunks +34 lines, -642 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
spang
Created Revert of Sync starting language and input method preferences
6 years ago (2014-12-01 19:53:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756363003/1
6 years ago (2014-12-01 19:55:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-01 19:55:59 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a140c96c6751e8dff5ed06f2e45978fb1c806f4 Cr-Commit-Position: refs/heads/master@{#306233}
6 years ago (2014-12-01 19:56:45 UTC) #4
michaelpg
6 years ago (2014-12-01 22:18:03 UTC) #5
Message was sent while issue was closed.
lgtm thanks for catching this.

Powered by Google App Engine
This is Rietveld 408576698