Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 756073004: De-generify the GenericNode. (Closed)

Created:
6 years ago by Michael Starzinger
Modified:
6 years ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

De-generify the GenericNode. R=titzer@chromium.org

Patch Set 1 #

Patch Set 2 : Fix compilation on Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -605 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/generic-algorithm.h View 2 chunks +7 lines, -6 lines 0 comments Download
M src/compiler/generic-algorithm-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
D src/compiler/generic-node.h View 1 chunk +0 lines, -278 lines 0 comments Download
D src/compiler/generic-node-inl.h View 1 chunk +0 lines, -267 lines 0 comments Download
M src/compiler/graph.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/graph-builder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-context-specialization.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/node.h View 1 4 chunks +417 lines, -11 lines 0 comments Download
M src/compiler/node.cc View 1 chunk +45 lines, -2 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/node-properties-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/select-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-basic-block-profiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-graph-reducer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-node.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-node-algorithm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-schedule.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Starzinger
6 years ago (2014-11-28 14:36:53 UTC) #1
titzer
omg gimme more LGTM so good
6 years ago (2014-11-28 14:50:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756073004/20001
6 years ago (2014-11-28 14:53:12 UTC) #4
commit-bot: I haz the power
6 years ago (2014-11-28 15:21:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698