Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: src/compiler/generic-algorithm.h

Issue 756073004: De-generify the GenericNode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compilation on Windows. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | src/compiler/generic-algorithm-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/generic-algorithm.h
diff --git a/src/compiler/generic-algorithm.h b/src/compiler/generic-algorithm.h
index 841cdd15b4292fc65bd5f7e9a1aa0600817f40d7..a755d2486033033f8b33a06e401b2a52c0255dfc 100644
--- a/src/compiler/generic-algorithm.h
+++ b/src/compiler/generic-algorithm.h
@@ -7,13 +7,15 @@
#include <stack>
-#include "src/compiler/generic-node.h"
#include "src/zone-containers.h"
namespace v8 {
namespace internal {
namespace compiler {
+class Graph;
+class Node;
+
// GenericGraphVisit allows visitation of graphs of nodes and edges in pre- and
// post-order. Visitation uses an explicitly allocated stack rather than the
// execution stack to avoid stack overflow. Although GenericGraphVisit is
@@ -88,12 +90,11 @@ class GenericGraphVisit {
Visit<Visitor, Traits>(graph, zone, &array[0], &array[1], visitor);
}
- template <class B, class S>
struct NullNodeVisitor {
- void Pre(GenericNode<B, S>* node) {}
- void Post(GenericNode<B, S>* node) {}
- void PreEdge(GenericNode<B, S>* from, int index, GenericNode<B, S>* to) {}
- void PostEdge(GenericNode<B, S>* from, int index, GenericNode<B, S>* to) {}
+ void Pre(Node* node) {}
+ void Post(Node* node) {}
+ void PreEdge(Node* from, int index, Node* to) {}
+ void PostEdge(Node* from, int index, Node* to) {}
};
private:
« no previous file with comments | « BUILD.gn ('k') | src/compiler/generic-algorithm-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698