Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 756053004: Make Document.getElementsByName() argument non-optional (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Make Document.getElementsByName() argument non-optional https://html.spec.whatwg.org/multipage/dom.html#document It's already non-optional in IE and Firefox. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M LayoutTests/fast/dom/Document/missing-arguments.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Document/missing-arguments-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
philipj_slow
PTAL
6 years ago (2014-11-26 07:10:21 UTC) #2
Mike West
Any idea what the usage is?
6 years ago (2014-11-26 08:00:36 UTC) #3
philipj_slow
No, there are no use counters for this. For comparison, https://codereview.chromium.org/133683004 made the same change ...
6 years ago (2014-11-26 08:15:21 UTC) #4
Mike West
Alright. Let's break things: LGTM.
6 years ago (2014-11-26 08:17:50 UTC) #5
philipj_slow
That's the spirit :)
6 years ago (2014-11-26 08:42:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756053004/1
6 years ago (2014-11-26 08:43:09 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-26 08:45:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186012

Powered by Google App Engine
This is Rietveld 408576698