Issue 133683004: Make arguments to Element methods non-optional (except setAttribute)

Issue 133683004: Make arguments to Element methods non-optional (except setAttribute) (Closed)

Created:
6 years, 11 months ago by philipj_slow

Modified:
6 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit), eseidel

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Make arguments to Element methods non-optional (except setAttribute) This partially re-lands <https://codereview.chromium.org/105883012/>;, which was reverted in <https://codereview.chromium.org/120373003>; because making the second argument to setAttribute broke Twitter. The second argument to setAttribute is left optional, making it non-optional will be attempted again separately. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164971

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -25 lines)			Patch
A	LayoutTests/fast/dom/Element/missing-arguments.html	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Element/missing-arguments-expected.txt	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/Element/script-tests/setAttributeNS-namespace-err.js	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/dom/Element/setAttributeNS-namespace-err-expected.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/dom/attribute-downcast-right.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Element.idl	View	2 chunks	+9 lines, -14 lines	0 comments	Download

Total messages: 6 (0 generated)

philipj_slow

For ease of review, https://codereview.chromium.org/130193003 is what has been removed from this CL compared to ...

6 years, 11 months ago (2014-01-13 08:00:54 UTC) #2

philipj_slow

(But I'm not submitting the setAttribute CL for review until I properly understand whether or ...

6 years, 11 months ago (2014-01-13 08:01:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/133683004/1

6 years, 11 months ago (2014-01-13 15:09:01 UTC) #5

Message was sent while issue was closed.

Change committed as 164971