Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 755843003: Remove compositing states from DocumentLifeCycle. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
esprehn
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove compositing states from DocumentLifeCycle. We not longer have compositing, so these states are gone. This was causing asserts to hit because we'd go from PaintInvalidationClean to InPaintInvalidation, which is now a valid transition if a new frame is pumped without style or layout being dirtied. Unfortunately, we can't test this until we fix test_sky to actually pump fake frames. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3adb12eeb817e07877eb07a9617cca75d2c1c1d7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -33 lines) Patch
M sky/engine/core/animation/DocumentAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/DocumentLifecycle.h View 3 chunks +1 line, -9 lines 0 comments Download
M sky/engine/core/dom/DocumentLifecycle.cpp View 3 chunks +2 lines, -11 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 5 chunks +6 lines, -10 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
ojan
https://codereview.chromium.org/755843003/diff/1/sky/engine/core/frame/FrameView.cpp File sky/engine/core/frame/FrameView.cpp (left): https://codereview.chromium.org/755843003/diff/1/sky/engine/core/frame/FrameView.cpp#oldcode907 sky/engine/core/frame/FrameView.cpp:907: void FrameView::invalidateTreeIfNeededRecursive() This used to walk the frame tree. ...
6 years ago (2014-12-02 17:16:42 UTC) #1
esprehn
lgtm
6 years ago (2014-12-02 17:43:05 UTC) #3
ojan
6 years ago (2014-12-02 18:13:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3adb12eeb817e07877eb07a9617cca75d2c1c1d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698