Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: sky/engine/core/dom/DocumentLifecycle.h

Issue 755843003: Remove compositing states from DocumentLifeCycle. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/dom/DocumentLifecycle.h
diff --git a/sky/engine/core/dom/DocumentLifecycle.h b/sky/engine/core/dom/DocumentLifecycle.h
index 2ef2c210583335349741c2ce2776f594fb7536f6..bee63b049bf90c6767498cd00a6b6e5f745fd4cf 100644
--- a/sky/engine/core/dom/DocumentLifecycle.h
+++ b/sky/engine/core/dom/DocumentLifecycle.h
@@ -55,9 +55,6 @@ public:
AfterPerformLayout,
LayoutClean,
- InCompositingUpdate,
- CompositingClean,
-
InPaintInvalidation,
PaintInvalidationClean,
@@ -146,11 +143,7 @@ private:
inline bool DocumentLifecycle::stateAllowsTreeMutations() const
{
- // FIXME: We should not allow mutations in InPreLayout or AfterPerformLayout either,
- // but we need to fix MediaList listeners and plugins first.
- return m_state != InStyleRecalc
- && m_state != InPerformLayout
- && m_state != InCompositingUpdate;
+ return m_state != InStyleRecalc && m_state != InPerformLayout;
}
inline bool DocumentLifecycle::stateAllowsRenderTreeMutations() const
@@ -165,7 +158,6 @@ inline bool DocumentLifecycle::stateAllowsDetach() const
|| m_state == StyleClean
|| m_state == InPreLayout
|| m_state == LayoutClean
- || m_state == CompositingClean
|| m_state == PaintInvalidationClean
|| m_state == Stopping;
}

Powered by Google App Engine
This is Rietveld 408576698