Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 755613007: Restore more webkit-font-smoothing. (Closed)

Created:
6 years ago by bungeman-chromium
Modified:
6 years ago
CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Restore more webkit-font-smoothing. With https://codereview.chromium.org/175253002 (Blink r182920) webkit-font-smoothing was broken on Mac. Blink 185065 restored webkit-font-smoothing when using non-subpixel-smoothed text, but did not fuly restore the previous behavior. This change should fully restore the previous behavior. BUG=chromium:435822 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185919

Patch Set 1 #

Patch Set 2 : Add rebaselines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/platform/fonts/mac/FontPlatformDataMac.mm View 1 chunk +22 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bungeman-chromium
The behavior being restored can be most easily seen at https://codereview.chromium.org/175253002/diff/660001/Source/platform/fonts/mac/FontMac.cpp#pair-77
6 years ago (2014-11-24 23:24:02 UTC) #3
bungeman-chromium
The behavior being restored can be most easily seen at https://codereview.chromium.org/175253002/diff/660001/Source/platform/fonts/mac/FontMac.cpp#pair-77
6 years ago (2014-11-24 23:24:02 UTC) #4
eae
LGTM
6 years ago (2014-11-24 23:25:44 UTC) #5
bungeman-chromium
On 2014/11/24 23:25:44, eae wrote: > LGTM The failing tests are all virtual/antialiased/ pixel tests ...
6 years ago (2014-11-25 01:16:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755613007/20001
6 years ago (2014-11-25 03:02:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=185919
6 years ago (2014-11-25 04:11:29 UTC) #9
Dominik Röttsches
6 years ago (2014-11-25 08:10:00 UTC) #10
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698