Source/core/rendering/RenderBox.h - Issue 755603002: RenderBox::updateLogicalHeight() doesn't need to be virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 755603002: RenderBox::updateLogicalHeight() doesn't need to be virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index 35c0b5434757fee874d9c856fae8d337750814da..189683e40cf62e25b61825f67a8bc01d72d3cb96 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -404,7 +404,7 @@ public:

LayoutUnit perpendicularContainingBlockLogicalHeight() const;

virtual void updateLogicalWidth();

- virtual void updateLogicalHeight();

+ void updateLogicalHeight();

virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const;

void computeLogicalWidth(LogicalExtentComputedValues&) const;

« no previous file with comments | « no previous file | no next file » | no next file with comments »