Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: Source/core/rendering/RenderBox.h

Issue 755603002: RenderBox::updateLogicalHeight() doesn't need to be virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 virtual void mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const o verride; 397 virtual void mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const o verride;
398 virtual void invalidatePaintForOverhangingFloats(bool paintAllDescendants); 398 virtual void invalidatePaintForOverhangingFloats(bool paintAllDescendants);
399 399
400 virtual LayoutUnit containingBlockLogicalWidthForContent() const override; 400 virtual LayoutUnit containingBlockLogicalWidthForContent() const override;
401 LayoutUnit containingBlockLogicalHeightForContent(AvailableLogicalHeightType ) const; 401 LayoutUnit containingBlockLogicalHeightForContent(AvailableLogicalHeightType ) const;
402 402
403 LayoutUnit containingBlockAvailableLineWidth() const; 403 LayoutUnit containingBlockAvailableLineWidth() const;
404 LayoutUnit perpendicularContainingBlockLogicalHeight() const; 404 LayoutUnit perpendicularContainingBlockLogicalHeight() const;
405 405
406 virtual void updateLogicalWidth(); 406 virtual void updateLogicalWidth();
407 virtual void updateLogicalHeight(); 407 void updateLogicalHeight();
408 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const; 408 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const;
409 409
410 void computeLogicalWidth(LogicalExtentComputedValues&) const; 410 void computeLogicalWidth(LogicalExtentComputedValues&) const;
411 411
412 bool stretchesToViewport() const 412 bool stretchesToViewport() const
413 { 413 {
414 return document().inQuirksMode() && style()->logicalHeight().isAuto() && !isFloatingOrOutOfFlowPositioned() && (isDocumentElement() || isBody()) && !isI nline(); 414 return document().inQuirksMode() && style()->logicalHeight().isAuto() && !isFloatingOrOutOfFlowPositioned() && (isDocumentElement() || isBody()) && !isI nline();
415 } 415 }
416 416
417 virtual LayoutSize intrinsicSize() const { return LayoutSize(); } 417 virtual LayoutSize intrinsicSize() const { return LayoutSize(); }
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
807 if (UNLIKELY(inlineBoxWrapper() != 0)) 807 if (UNLIKELY(inlineBoxWrapper() != 0))
808 deleteLineBoxWrapper(); 808 deleteLineBoxWrapper();
809 } 809 }
810 810
811 ensureRareData().m_inlineBoxWrapper = boxWrapper; 811 ensureRareData().m_inlineBoxWrapper = boxWrapper;
812 } 812 }
813 813
814 } // namespace blink 814 } // namespace blink
815 815
816 #endif // RenderBox_h 816 #endif // RenderBox_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698