Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: src/typing.cc

Issue 755513003: Hydrogen: fix keyed loads with string keys (Closed) Base URL: gh:v8/v8@master
Patch Set: rebase again Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/type-info.cc ('k') | test/mjsunit/keyed-load-with-string-key.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index 0bfe3af997d023779078bdb5a6d4451af9a80d82..88c530eeee7bca2a38d78c187b8384fb1f5ed5f9 100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -507,14 +507,17 @@ void AstTyper::VisitProperty(Property* expr) {
}
} else {
bool is_string;
+ IcCheckType key_type;
if (FLAG_vector_ics) {
oracle()->KeyedPropertyReceiverTypes(slot, expr->GetReceiverTypes(),
&is_string);
+ key_type = ELEMENT;
Jakob Kummerow 2014/12/15 13:07:57 Yeah, actually this is a problem, because it means
} else {
oracle()->KeyedPropertyReceiverTypes(id, expr->GetReceiverTypes(),
- &is_string);
+ &is_string, &key_type);
}
expr->set_is_string_access(is_string);
+ expr->set_key_type(key_type);
}
}
« no previous file with comments | « src/type-info.cc ('k') | test/mjsunit/keyed-load-with-string-key.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698