Hydrogen: fix keyed loads with string keys

src/typing.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/typing.h"
 
 #include "src/frames.h"
 #include "src/frames-inl.h"
 #include "src/ostreams.h"
 #include "src/parser.h"  // for CompileTimeValue; TODO(rossberg): should move
@@ skipping 489 matching lines @@
       Literal* lit_key = expr->key()->AsLiteral();
       DCHECK(lit_key != NULL && lit_key->value()->IsString());
       Handle<String> name = Handle<String>::cast(lit_key->value());
       if (FLAG_vector_ics) {
         oracle()->PropertyReceiverTypes(slot, name, expr->GetReceiverTypes());
       } else {
         oracle()->PropertyReceiverTypes(id, name, expr->GetReceiverTypes());
       }
     } else {
       bool is_string;
+      IcCheckType key_type;
       if (FLAG_vector_ics) {
         oracle()->KeyedPropertyReceiverTypes(slot, expr->GetReceiverTypes(),
                                              &is_string);
+        key_type = ELEMENT;

[Jakob Kummerow, 2014/12/15 13:07:57]

Yeah, actually this is a problem, because it means --vector-ics (which is the
future) will break this mechanism. But I've talked to mvstanton@ and he's
graciously offered to add support for this to the --vector-ics system.

       } else {
         oracle()->KeyedPropertyReceiverTypes(id, expr->GetReceiverTypes(),
-                                             &is_string);
+                                             &is_string, &key_type);
       }
       expr->set_is_string_access(is_string);
+      expr->set_key_type(key_type);
     }
   }
 
   RECURSE(Visit(expr->obj()));
   RECURSE(Visit(expr->key()));
 
   // We don't know anything about the result type.
 }
 
 
@@ skipping 278 matching lines @@
 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
 }
 
 
 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
   RECURSE(Visit(stmt->body()));
 }
 
 
 } }  // namespace v8::internal