Issue 75543008: Fix alignment for bubbles with center-arrows.

Issue 75543008: Fix alignment for bubbles with center-arrows. (Closed)

Created:
7 years, 1 month ago by groby-ooo-7-16

Modified:
7 years, 1 month ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix alignment for bubbles with center-arrows. BUG=320910 R=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236121

Patch Set 2 : Kill blank line. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -4 lines)			Patch
	M	chrome/browser/ui/cocoa/base_bubble_controller.mm	View		1 chunk	+13 lines, -4 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

LGTM https://codereview.chromium.org/75543008/diff/1/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm File chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm (right): https://codereview.chromium.org/75543008/diff/1/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm#newcode132 chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm:132: nit: extra blank line

7 years, 1 month ago (2013-11-19 15:54:14 UTC) #2

groby-ooo-7-16

https://codereview.chromium.org/75543008/diff/1/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm File chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm (right): https://codereview.chromium.org/75543008/diff/1/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm#newcode132 chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm:132: On 2013/11/19 15:54:14, rsesek wrote: > nit: extra blank ...

7 years, 1 month ago (2013-11-19 18:59:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/75543008/50001

7 years, 1 month ago (2013-11-19 19:08:22 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=176361

7 years, 1 month ago (2013-11-19 22:25:17 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/75543008/50001

7 years, 1 month ago (2013-11-20 01:16:26 UTC) #6

Message was sent while issue was closed.

Change committed as 236121

Expand Messages | Collapse Messages