Fix alignment for bubbles with center-arrows.

chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 #include "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
@@ skipping 96 matching lines @@
   NSRect frame = [[controller_ window] frame];
   // Make sure the bubble size hasn't changed.
   EXPECT_EQ(frame.size.width, kBubbleWindowWidth);
   EXPECT_EQ(frame.size.height, kBubbleWindowHeight);
   // Make sure the bubble arrow points to the anchor.
   EXPECT_EQ(NSMaxX(frame) - info_bubble::kBubbleArrowXOffset -
       floorf(info_bubble::kBubbleArrowWidth / 2.0), kAnchorPointX);
   EXPECT_GE(NSMaxY(frame), kAnchorPointY);
 }
 
+// Test that kAlignArrowToAnchor and a center bubble arrow correctly align
+// the bubble towards the anchor point.
+TEST_F(BaseBubbleControllerTest, AnchorAlignCenterArrow) {
+  [[controller_ bubble] setArrowLocation:info_bubble::kTopCenter];
+  [[controller_ bubble] setAlignment:info_bubble::kAlignArrowToAnchor];
+  [controller_ showWindow:nil];
+
+  NSRect frame = [[controller_ window] frame];
+  // Make sure the bubble size hasn't changed.
+  EXPECT_EQ(frame.size.width, kBubbleWindowWidth);
+  EXPECT_EQ(frame.size.height, kBubbleWindowHeight);
+  // Make sure the bubble arrow points to the anchor.
+  EXPECT_EQ(NSMidX(frame), kAnchorPointX);
+  EXPECT_GE(NSMaxY(frame), kAnchorPointY);
+}
+

[Robert Sesek, 2013/11/19 15:54:14]

nit: extra blank line

[groby-ooo-7-16, 2013/11/19 18:59:48]

Done.

+
 // Tests that when a new window gets key state (and the bubble resigns) that
 // the key window changes.
 TEST_F(BaseBubbleControllerTest, ResignKeyCloses) {
   // Closing the bubble will autorelease the controller.
   base::scoped_nsobject<BaseBubbleController> keep_alive([controller_ retain]);
 
   NSWindow* bubble_window = [controller_ window];
   EXPECT_FALSE([bubble_window isVisible]);
 
   base::scoped_nsobject<NSWindow> other_window(
@@ skipping 56 matching lines @@
   EXPECT_TRUE([window isVisible]);
 
   [controller_ setShouldCloseOnResignKey:YES];
   event = cocoa_test_event_utils::LeftMouseDownAtPointInWindow(
       NSMakePoint(10, 10), test_window());
   [NSApp sendEvent:event];
   chrome::testing::NSRunLoopRunAllPending();
 
   EXPECT_FALSE([window isVisible]);
 }