Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 755413002: No quirky colors for border-top/left/right/bottom shorthands. (Closed)

Created:
6 years ago by rune
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

No quirky colors for border-top/left/right/bottom shorthands. The only border shorthand that allows hashless colors in quirks mode is border-color according to [1]. [1] http://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk R=timloh@chromium.org BUG=391343 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185991

Patch Set 1 #

Patch Set 2 : Missing test for border shorthand #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M LayoutTests/fast/css/parsing-color-quirk.html View 1 2 chunks +26 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
6 years ago (2014-11-25 23:49:50 UTC) #1
Timothy Loh
On 2014/11/25 23:49:50, rune wrote: lgtm
6 years ago (2014-11-25 23:52:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755413002/20001
6 years ago (2014-11-25 23:58:16 UTC) #4
commit-bot: I haz the power
6 years ago (2014-11-26 01:48:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185991

Powered by Google App Engine
This is Rietveld 408576698