Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 755413002: No quirky colors for border-top/left/right/bottom shorthands. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Missing test for border shorthand Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css/parsing-color-quirk.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 7feb07b4a48960ea2a2e5239ebe093afee6063c7..46ca550c5dfe4a9bbe088042911795c926b29d61 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -606,13 +606,13 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId, bool important)
bool acceptQuirkyColors = false;
switch (propId) {
case CSSPropertyBackgroundColor:
- if (!inShorthand())
- acceptQuirkyColors = true;
- break;
case CSSPropertyBorderBottomColor:
case CSSPropertyBorderLeftColor:
case CSSPropertyBorderRightColor:
case CSSPropertyBorderTopColor:
+ if (!inShorthand() || m_currentShorthand == CSSPropertyBorderColor)
+ acceptQuirkyColors = true;
+ break;
case CSSPropertyColor:
acceptQuirkyColors = true;
break;
« no previous file with comments | « LayoutTests/fast/css/parsing-color-quirk.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698