Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 755403006: Added experimental Touch.tilt, Touch.tiltDirection support for Android (Closed)

Created:
6 years ago by d.pikalov
Modified:
5 years, 7 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, tdresser+watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, jdduke+watch_chromium.org, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

For a stylus, Touch.tilt reports the angle of the stylus in degrees, in range [0, 90). Touch.tiltDirection is an clockwise angle [-180..180) in relation to the 0X axis. The angle indicates the direction in which the stylus is tilted. Currently available behind the enable-experimental-web-platform-features flag. Draft spec: https://docs.google.com/document/d/1hRjHN9T3RBKJV6LL6WQMEaw35YD_T-G41X-ZciW18xU/edit A link to the Blink patch (https://codereview.chromium.org/750013004/) BUG=393462

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comments about GetTilt() #

Patch Set 3 : Merge with 'master' #

Patch Set 4 : Added Touch.tiltDirection, minor refactoring #

Patch Set 5 : Added support of Touch.tilt, Touch.tiltDirection for tests #

Patch Set 6 : Added logic to detect whether Tilt, TiltDirection are supported (use NaN value, if not) #

Total comments: 2

Patch Set 7 : Added EventSender.SetTouchPointTilt() for tests #

Total comments: 2

Patch Set 8 : Merged with master. UpdateTouchPoint() fixed #

Patch Set 9 : Added param 'set_state_moved' to EventSender::SetTouchPointTilt() #

Total comments: 2

Patch Set 10 : Merged with master #

Patch Set 11 : Remove unused code (event_sender.cc) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -10 lines) Patch
M AUTHORS View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_android.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_android.cc View 1 2 3 4 5 6 7 3 chunks +20 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/motion_event_web.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_web.cc View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.cc View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util_unittest.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M content/common/input/web_input_event_traits.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M content/content.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/content_jni.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/MotionEventUtil.java View 1 2 3 4 5 1 chunk +28 lines, -0 lines 0 comments Download
M content/renderer/pepper/event_conversion.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/pepper/event_conversion_unittest.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.h View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 1 2 3 4 5 6 7 8 9 10 5 chunks +32 lines, -3 lines 0 comments Download
M ui/events/cocoa/events_mac.mm View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M ui/events/event.h View 1 2 3 4 5 6 7 4 chunks +15 lines, -1 line 0 comments Download
M ui/events/event.cc View 1 2 3 4 5 6 7 4 chunks +9 lines, -1 line 0 comments Download
M ui/events/event_utils.h View 1 2 3 4 5 6 7 1 chunk +9 lines, -0 lines 0 comments Download
M ui/events/events_stub.cc View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/motion_event.h View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic.cc View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M ui/events/ozone/events_ozone.cc View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M ui/events/test/event_generator.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ui/events/win/events_win.cc View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
jdduke (slow)
On 2014/11/26 16:10:33, d.pikalov wrote: > mailto:d.pikalov@partner.samsung.com changed reviewers: > + mailto:jdduke@chromium.org, mailto:raymes@chromium.org There's no ...
6 years ago (2014-11-26 18:07:26 UTC) #2
jdduke (slow)
Please include in the description: A link to the Blink patch (https://codereview.chromium.org/750013004/) A link to ...
6 years ago (2014-11-26 18:13:29 UTC) #3
d.pikalov
On 2014/11/26 18:07:26, jdduke wrote: > On 2014/11/26 16:10:33, d.pikalov wrote: > > mailto:d.pikalov@partner.samsung.com changed ...
6 years ago (2014-11-28 13:27:45 UTC) #4
d.pikalov
https://codereview.chromium.org/755403006/diff/1/ui/events/gesture_detection/motion_event.h File ui/events/gesture_detection/motion_event.h (right): https://codereview.chromium.org/755403006/diff/1/ui/events/gesture_detection/motion_event.h#newcode98 ui/events/gesture_detection/motion_event.h:98: float GetTilt() const { return GetTilt(0); } On 2014/11/26 ...
6 years ago (2014-11-28 13:55:13 UTC) #5
jdduke (slow)
https://codereview.chromium.org/755403006/diff/100001/ui/events/gesture_detection/motion_event.h File ui/events/gesture_detection/motion_event.h (right): https://codereview.chromium.org/755403006/diff/100001/ui/events/gesture_detection/motion_event.h#newcode63 ui/events/gesture_detection/motion_event.h:63: virtual float GetTilt(size_t pointer_index) const = 0; Interesting, it ...
5 years, 10 months ago (2015-02-20 16:20:13 UTC) #7
Rick Byers
https://codereview.chromium.org/755403006/diff/100001/ui/events/gesture_detection/motion_event.h File ui/events/gesture_detection/motion_event.h (right): https://codereview.chromium.org/755403006/diff/100001/ui/events/gesture_detection/motion_event.h#newcode63 ui/events/gesture_detection/motion_event.h:63: virtual float GetTilt(size_t pointer_index) const = 0; On 2015/02/20 ...
5 years, 10 months ago (2015-02-20 21:19:08 UTC) #9
d.pikalov
5 years, 9 months ago (2015-03-05 14:35:13 UTC) #10
Rick Byers
Reviewed event_sender changes. https://codereview.chromium.org/755403006/diff/120001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/755403006/diff/120001/content/shell/renderer/test_runner/event_sender.cc#newcode1567 content/shell/renderer/test_runner/event_sender.cc:1567: if (!args->PeekNext().IsEmpty()) { Is there a ...
5 years, 9 months ago (2015-03-05 15:01:02 UTC) #11
d.pikalov
https://codereview.chromium.org/755403006/diff/120001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/755403006/diff/120001/content/shell/renderer/test_runner/event_sender.cc#newcode1567 content/shell/renderer/test_runner/event_sender.cc:1567: if (!args->PeekNext().IsEmpty()) { On 2015/03/05 15:01:02, Rick Byers wrote: ...
5 years, 9 months ago (2015-03-09 13:39:50 UTC) #12
d.pikalov
Added parameter bool 'set_state_moved' to eventSender.SetTouchPointTilt()
5 years, 9 months ago (2015-03-17 10:51:39 UTC) #13
Rick Byers
https://codereview.chromium.org/755403006/diff/160001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/755403006/diff/160001/content/shell/renderer/test_runner/event_sender.cc#newcode1821 content/shell/renderer/test_runner/event_sender.cc:1821: if (!args->PeekNext().IsEmpty()) { you can remove this chunk now, ...
5 years, 9 months ago (2015-03-17 14:40:35 UTC) #14
d.pikalov
5 years, 9 months ago (2015-03-17 16:15:07 UTC) #15
Done

https://codereview.chromium.org/755403006/diff/160001/content/shell/renderer/...
File content/shell/renderer/test_runner/event_sender.cc (right):

https://codereview.chromium.org/755403006/diff/160001/content/shell/renderer/...
content/shell/renderer/test_runner/event_sender.cc:1821: if
(!args->PeekNext().IsEmpty()) {
On 2015/03/17 14:40:35, Rick Byers wrote:
> you can remove this chunk now, right?

Done. I'll remove chunk for radius in CL 990183003

Powered by Google App Engine
This is Rietveld 408576698