Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: src/hydrogen.cc

Issue 755333003: Do not try to inline if the function has an illegal redeclaration. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix license Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-436896.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 1d33bfa6126c7ed6ed889440934b0835616f1fde..eec5de3a0c23004efeeec5ad0d206dfc37ea157e 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -7931,6 +7931,11 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
return false;
}
+ if (target_info.scope()->HasIllegalRedeclaration()) {
+ TraceInline(target, caller, "target has illegal redeclaration");
+ return false;
+ }
+
if (target_info.scope()->num_heap_slots() > 0) {
TraceInline(target, caller, "target has context-allocated variables");
return false;
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-436896.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698