Issue 755313011: Fix java bindings with array of maps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 755313011: Fix java bindings with array of maps. (Closed)

Created:
6 years ago by qsr

Modified:
6 years ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix java bindings with array of maps. In java, this is incorrect: new Map<Foo, Bar>[3] This CL makes sure we do not specify generic when instantiating an array. Also, re-enables tests for array of maps. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/05c78d33334e8f84157975297f89b2ab01338fca

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	mojo/public/interfaces/bindings/tests/test_structs.mojom	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/public/js/struct_unittests.js	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	mojo/public/tools/bindings/generators/mojom_java_generator.py	View	3 chunks	+12 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

Could you summarize briefly what was the problem (in the commit description) / what wasn't ...

6 years ago (2014-12-10 10:48:36 UTC) #2

qsr

6 years ago (2014-12-10 13:52:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
05c78d33334e8f84157975297f89b2ab01338fca (presubmit successful).

Expand Messages | Collapse Messages