Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: mojo/public/js/struct_unittests.js

Issue 755313011: Fix java bindings with array of maps. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/js/struct_unittests.js
diff --git a/mojo/public/js/struct_unittests.js b/mojo/public/js/struct_unittests.js
index 3c5186d0ada6ec2477dd0a73bc4f0dae92e53349..2288fc78751dd50b0389324dd28f03e4526a914d 100644
--- a/mojo/public/js/struct_unittests.js
+++ b/mojo/public/js/struct_unittests.js
@@ -156,14 +156,11 @@ define([
// array<array<string, 2>, 1>>
f5: new Map([["a", [["1", "2"]]]]),
// map<string, Rect?>
- /*
- Disabled until the Java bindings work correctly.
f6: new Map([["a", null]]),
// map<string, map<string, string>>
f7: new Map([["a", new Map([["b", "c"]])]]),
// map<string, array<map<string, string>>>
f8: new Map([["a", [new Map([["b", "c"]])]]]),
- */
});
var decodedStruct = structEncodeDecode(mapFieldsStruct);
expect(decodedStruct.f0).toEqual(mapFieldsStruct.f0);
@@ -172,12 +169,9 @@ define([
expect(decodedStruct.f3).toEqual(mapFieldsStruct.f3);
expect(decodedStruct.f4).toEqual(mapFieldsStruct.f4);
expect(decodedStruct.f5).toEqual(mapFieldsStruct.f5);
- /*
- Disabled until the Java bindings work correctly.
expect(decodedStruct.f6).toEqual(mapFieldsStruct.f6);
expect(decodedStruct.f7).toEqual(mapFieldsStruct.f7);
expect(decodedStruct.f8).toEqual(mapFieldsStruct.f8);
- */
}
testConstructors();

Powered by Google App Engine
This is Rietveld 408576698