Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 755313004: Pass Mach message trailers to server handler functions (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Pass Mach message trailers to server handler functions. TEST=util_test ChildPortServer.*:ExcServerVariants.*:MachMessageUtil.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/0437bc53b660a43027dd938ac9752407bf705ebc

Patch Set 1 #

Patch Set 2 : Use REQUESTED_TRAILER_SIZE() #

Total comments: 1

Patch Set 3 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -46 lines) Patch
M client/simulate_crash_mac_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M snapshot/mac/mach_o_image_annotations_reader_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/catch_exception_tool.cc View 1 chunk +1 line, -0 lines 0 comments Download
M util/mach/child_port_handshake.h View 1 chunk +1 line, -0 lines 0 comments Download
M util/mach/child_port_handshake.cc View 1 chunk +1 line, -0 lines 0 comments Download
M util/mach/child_port_server.h View 2 chunks +2 lines, -0 lines 0 comments Download
M util/mach/child_port_server.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M util/mach/child_port_server_test.cc View 5 chunks +6 lines, -3 lines 0 comments Download
M util/mach/exc_client_variants_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M util/mach/exc_server_variants.h View 20 chunks +27 lines, -4 lines 0 comments Download
M util/mach/exc_server_variants.cc View 22 chunks +30 lines, -4 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 1 2 35 chunks +79 lines, -30 lines 0 comments Download
M util/mach/exception_ports_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M util/mach/mach_message_server.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M util/mach/mach_message_util.h View 1 chunk +14 lines, -0 lines 0 comments Download
M util/mach/mach_message_util.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M util/mach/mach_message_util_test.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
It bugged me that you’d lose the ability to receive a message trailer that was ...
6 years ago (2014-11-25 21:54:14 UTC) #2
Robert Sesek
https://codereview.chromium.org/755313004/diff/20001/util/mach/exc_server_variants_test.cc File util/mach/exc_server_variants_test.cc (right): https://codereview.chromium.org/755313004/diff/20001/util/mach/exc_server_variants_test.cc#newcode172 util/mach/exc_server_variants_test.cc:172: const mach_msg_trailer_t* Trailer() const { Why not use the ...
6 years ago (2014-12-01 20:51:39 UTC) #3
Mark Mentovai
Good point. Updated.
6 years ago (2014-12-01 20:59:32 UTC) #4
Robert Sesek
LGTM
6 years ago (2014-12-01 21:02:43 UTC) #5
Mark Mentovai
6 years ago (2014-12-01 21:07:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0437bc53b660a43027dd938ac9752407bf705ebc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698