Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 755293003: disable aero glass for Vista. (Closed)

Created:
6 years ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

disable aero glass for Vista. This better aligns XP and Vista, for maintenance purposes. BUG=426573 Committed: https://crrev.com/f29562d138f8c2222c6f24bddbd1a665ed036658 Cr-Commit-Position: refs/heads/master@{#307354}

Patch Set 1 #

Total comments: 2

Patch Set 2 : scotts nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/base/win/shell.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
cpu_(ooo_6.6-7.5)
ptal
6 years ago (2014-12-05 22:35:24 UTC) #2
scottmg
lgtm https://codereview.chromium.org/755293003/diff/1/ui/base/win/shell.cc File ui/base/win/shell.cc (right): https://codereview.chromium.org/755293003/diff/1/ui/base/win/shell.cc#newcode152 ui/base/win/shell.cc:152: base::debug::Alias(&version); // TODO(scottmg): http://crbug.com/431549. This is unnecessary now, ...
6 years ago (2014-12-05 22:39:55 UTC) #4
cpu_(ooo_6.6-7.5)
done with scott's comments.
6 years ago (2014-12-06 03:37:11 UTC) #5
grt (UTC plus 2)
lgtm
6 years ago (2014-12-06 04:13:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755293003/20001
6 years ago (2014-12-08 21:10:41 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-08 22:19:35 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f29562d138f8c2222c6f24bddbd1a665ed036658 Cr-Commit-Position: refs/heads/master@{#307354}
6 years ago (2014-12-08 22:20:31 UTC) #10
ebraminio
5 years, 9 months ago (2015-03-16 00:08:00 UTC) #11
Message was sent while issue was closed.
This probably worth to be reverted, Chrome 41 is not even roled on stable
channel but the http://crbug.com/451733 got 30 star and many people are
disappointed of this.

Powered by Google App Engine
This is Rietveld 408576698