Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 755213002: Let NamedNodeMap take and return Attr instead of Node (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Let NamedNodeMap take and return Attr instead of Node https://dom.spec.whatwg.org/#namednodemap The Attr arguments are also made non-optional. This makes for less error handling in C++. R=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185973

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -42 lines) Patch
M LayoutTests/dom/html/level2/core/hc_namednodemapinvalidtype1.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js View 1 chunk +2 lines, -2 lines 2 comments Download
A LayoutTests/fast/dom/NamedNodeMap-missing-arguments.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/NamedNodeMap-missing-arguments-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NamedNodeMap.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 3 chunks +11 lines, -20 lines 0 comments Download
M Source/core/dom/NamedNodeMap.idl View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
philipj_slow
PTAL
6 years ago (2014-11-25 13:54:21 UTC) #2
Mike West
Love it. LGTM, thanks! https://codereview.chromium.org/755213002/diff/1/LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js File LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js (right): https://codereview.chromium.org/755213002/diff/1/LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js#newcode114 LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js:114: assertTrue("throw_TYPE_ERR",success); Tabs? :(
6 years ago (2014-11-25 14:04:02 UTC) #3
philipj_slow
https://codereview.chromium.org/755213002/diff/1/LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js File LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js (right): https://codereview.chromium.org/755213002/diff/1/LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js#newcode114 LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js:114: assertTrue("throw_TYPE_ERR",success); On 2014/11/25 14:04:01, Mike West wrote: > Tabs? ...
6 years ago (2014-11-25 14:46:54 UTC) #4
Mike West
On 2014/11/25 14:46:54, philipj wrote: > https://codereview.chromium.org/755213002/diff/1/LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js > File LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js (right): > > https://codereview.chromium.org/755213002/diff/1/LayoutTests/dom/xhtml/level2/core/hc_namednodemapinvalidtype1.js#newcode114 > ...
6 years ago (2014-11-25 14:48:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755213002/1
6 years ago (2014-11-25 16:01:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/20687)
6 years ago (2014-11-25 16:06:07 UTC) #9
philipj_slow
6 years ago (2014-11-25 20:54:39 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 185973 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698