Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: Source/core/dom/NamedNodeMap.h

Issue 755213002: Let NamedNodeMap take and return Attr instead of Node (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/NamedNodeMap.h
diff --git a/Source/core/dom/NamedNodeMap.h b/Source/core/dom/NamedNodeMap.h
index f4d544289dc5622aa6cfe1eb2d0f4dcf92f100aa..4f1562553226765728f61fc9d355551bc71df419 100644
--- a/Source/core/dom/NamedNodeMap.h
+++ b/Source/core/dom/NamedNodeMap.h
@@ -33,7 +33,7 @@
namespace blink {
-class Node;
+class Attr;
class ExceptionState;
class NamedNodeMap final : public NoBaseWillBeGarbageCollected<NamedNodeMap>, public ScriptWrappable {
@@ -53,16 +53,16 @@ public:
// Public DOM interface.
- PassRefPtrWillBeRawPtr<Node> getNamedItem(const AtomicString&) const;
- PassRefPtrWillBeRawPtr<Node> removeNamedItem(const AtomicString& name, ExceptionState&);
+ PassRefPtrWillBeRawPtr<Attr> getNamedItem(const AtomicString&) const;
+ PassRefPtrWillBeRawPtr<Attr> removeNamedItem(const AtomicString& name, ExceptionState&);
- PassRefPtrWillBeRawPtr<Node> getNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName) const;
- PassRefPtrWillBeRawPtr<Node> removeNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName, ExceptionState&);
+ PassRefPtrWillBeRawPtr<Attr> getNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName) const;
+ PassRefPtrWillBeRawPtr<Attr> removeNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName, ExceptionState&);
- PassRefPtrWillBeRawPtr<Node> setNamedItem(Node*, ExceptionState&);
- PassRefPtrWillBeRawPtr<Node> setNamedItemNS(Node*, ExceptionState&);
+ PassRefPtrWillBeRawPtr<Attr> setNamedItem(Attr*, ExceptionState&);
+ PassRefPtrWillBeRawPtr<Attr> setNamedItemNS(Attr*, ExceptionState&);
- PassRefPtrWillBeRawPtr<Node> item(unsigned index) const;
+ PassRefPtrWillBeRawPtr<Attr> item(unsigned index) const;
size_t length() const;
Element* element() const { return m_element; }

Powered by Google App Engine
This is Rietveld 408576698