Chromium Code Reviews

Issue 754963008: Simplify //mojo/public/c/system targets (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Simplify //mojo/public/c/system targets We don't support building mojo apps in the component build, so we can simplify these system targets a bit. We don't need to have everything depend on a forwarding group that always evaluates to the same thing in the mojo repo. The new targets are: //mojo/public/c/system which contains the system headers but no implementation. //mojo/public/platform/native:system which contains the system thunks and exported thunk setter, used by anything run by the shell. This is mostly used by the mojo_native_application template but is also used by a few targets that need to link as shared_lib but will ultimately be loaded by the shell. //mojo/edk/system provides the real implementation of the system calls and is used by the shell and a few tests. The :for_... groups need to stick around for now to keep chromium working, but once this rolls in to the chromium tree then these can be fixed up as well. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3bfa8fdadb7917ebd25947ac7a8fbb2e2273d8dc

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+56 lines, -42 lines)
M examples/device_name/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments
M mojo/go/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments
M mojo/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M mojo/public/c/gles2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M mojo/public/c/system/BUILD.gn View 1 chunk +3 lines, -9 lines 0 comments
M mojo/public/mojo_application.gni View 6 chunks +25 lines, -12 lines 0 comments
M mojo/public/platform/native/BUILD.gn View 2 chunks +2 lines, -9 lines 0 comments
M mojo/public/python/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments
M sky/engine/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M sky/engine/platform/BUILD.gn View 3 chunks +8 lines, -4 lines 0 comments
M sky/engine/web/BUILD.gn View 2 chunks +7 lines, -1 line 0 comments

Messages

Total messages: 3 (0 generated)
viettrungluu
LGTM w/two fixes. (I assume that abarth is OK with his new TODOs.) https://codereview.chromium.org/754963008/diff/1/examples/device_name/BUILD.gn File ...
6 years ago (2014-12-08 23:16:34 UTC) #1
jamesr
Thanks. eseidel@ said that Adam was OK with these TODOs https://codereview.chromium.org/754963008/diff/1/examples/device_name/BUILD.gn File examples/device_name/BUILD.gn (right): https://codereview.chromium.org/754963008/diff/1/examples/device_name/BUILD.gn#newcode17 ...
6 years ago (2014-12-09 01:20:32 UTC) #2
jamesr
6 years ago (2014-12-10 21:56:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3bfa8fdadb7917ebd25947ac7a8fbb2e2273d8dc (presubmit successful).

Powered by Google App Engine