Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: sky/engine/platform/BUILD.gn

Issue 754963008: Simplify //mojo/public/c/system targets (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/BUILD.gn ('k') | sky/engine/web/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/BUILD.gn
diff --git a/sky/engine/platform/BUILD.gn b/sky/engine/platform/BUILD.gn
index 8b1f5e1b24b90587462eebbc55e584a67a03a509..e43e4fff9c2718d8f191edffec9e003f66344e52 100644
--- a/sky/engine/platform/BUILD.gn
+++ b/sky/engine/platform/BUILD.gn
@@ -84,11 +84,9 @@ group("make_platform_generated") {
]
}
-component("platform") {
+source_set("platform") {
visibility += [ "//sky/*" ]
- output_name = "sky_platform"
-
sources = [
"animation/AnimationUtilities.h",
"animation/AnimationValue.h",
@@ -644,7 +642,7 @@ component("platform") {
"//mojo/application",
"//mojo/common",
"//mojo/environment:chromium",
- "//mojo/public/c/system:for_shared_library",
+ "//mojo/public/c/system",
"//mojo/public/cpp/bindings",
"//mojo/public/cpp/system",
"//mojo/public/cpp/utility",
@@ -756,6 +754,12 @@ test("platform_unittests") {
"//url",
]
+ # TODO(abarth): This is a lie - this test is not embedded in an environment
+ # that injects the system thunks, so system calls don't actually work. This
+ # just tricks the linker into thinking that an implementation of these calls
+ # will be injected at runtime so the link succeeds.
+ deps += [ "//mojo/public/platform/native:system" ]
+
defines = [ "INSIDE_BLINK" ]
include_dirs = [ "$root_build_dir" ]
« no previous file with comments | « sky/engine/core/BUILD.gn ('k') | sky/engine/web/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698