Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 754903002: Sync up PRESUBMIT.py with Chromium CQ config. (Closed)

Created:
6 years ago by Sergey Berezin
Modified:
6 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Sync up PRESUBMIT.py with Chromium CQ config. Now 'git cl try' should trigger exactly the jobs that CQ expects. Once these pass, CQ should commit immediately. R=phajdan.jr@chromium.org BUG=None TEST=git cl try (succeeded); subsequent CQ run should commit immediately. Committed: https://crrev.com/937b35322a6d4dff40c813b91f068254fce53750 Cr-Commit-Position: refs/heads/master@{#305701}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed cros_x86 (stale builder) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M PRESUBMIT.py View 1 7 chunks +12 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Sergey Berezin
PTAL. This CL was prompted by https://codereview.chromium.org/751613004/ when CQ started more jobs after all 'git ...
6 years ago (2014-11-24 19:46:44 UTC) #1
Paweł Hajdan Jr.
LGTM w/ optional comment. https://codereview.chromium.org/754903002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/754903002/diff/1/PRESUBMIT.py#newcode1752 PRESUBMIT.py:1752: builders.extend(['cros_x86']) I think this builder ...
6 years ago (2014-11-25 13:02:05 UTC) #2
Sergey Berezin
Addressed the comment, will run 'git cl try' before CQ to test the sync-up end-to-end. ...
6 years ago (2014-11-25 20:25:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754903002/20001
6 years ago (2014-11-25 21:41:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-25 21:44:18 UTC) #6
Sergey Berezin
On 2014/11/25 21:44:18, I haz the power (commit-bot) wrote: > Committed patchset #2 (id:20001) Worked ...
6 years ago (2014-11-25 21:45:56 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-25 21:47:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/937b35322a6d4dff40c813b91f068254fce53750
Cr-Commit-Position: refs/heads/master@{#305701}

Powered by Google App Engine
This is Rietveld 408576698