| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 1582 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1593 # incremental build. Reference: | 1593 # incremental build. Reference: |
| 1594 # http://chromium.org/developers/tree-sheriffs/perf-sheriffs. | 1594 # http://chromium.org/developers/tree-sheriffs/perf-sheriffs. |
| 1595 # TODO(maruel): An option would be to run 'sizes' but not count a failure | 1595 # TODO(maruel): An option would be to run 'sizes' but not count a failure |
| 1596 # of this step as a try job failure. | 1596 # of this step as a try job failure. |
| 1597 'android_aosp': ['compile'], | 1597 'android_aosp': ['compile'], |
| 1598 'android_arm64_dbg_recipe': ['slave_steps'], | 1598 'android_arm64_dbg_recipe': ['slave_steps'], |
| 1599 'android_chromium_gn_compile_dbg': ['compile'], | 1599 'android_chromium_gn_compile_dbg': ['compile'], |
| 1600 'android_chromium_gn_compile_rel': ['compile'], | 1600 'android_chromium_gn_compile_rel': ['compile'], |
| 1601 'android_clang_dbg_recipe': ['slave_steps'], | 1601 'android_clang_dbg_recipe': ['slave_steps'], |
| 1602 'android_dbg_tests_recipe': ['slave_steps'], | 1602 'android_dbg_tests_recipe': ['slave_steps'], |
| 1603 'cros_x86': ['defaulttests'], | |
| 1604 'ios_dbg_simulator': [ | 1603 'ios_dbg_simulator': [ |
| 1605 'compile', | 1604 'compile', |
| 1606 'base_unittests', | 1605 'base_unittests', |
| 1607 'content_unittests', | 1606 'content_unittests', |
| 1608 'crypto_unittests', | 1607 'crypto_unittests', |
| 1609 'url_unittests', | 1608 'url_unittests', |
| 1610 'net_unittests', | 1609 'net_unittests', |
| 1611 'sql_unittests', | 1610 'sql_unittests', |
| 1612 'ui_base_unittests', | 1611 'ui_base_unittests', |
| 1613 ], | 1612 ], |
| 1614 'ios_rel_device': ['compile'], | 1613 'ios_rel_device': ['compile'], |
| 1615 'ios_rel_device_ninja': ['compile'], | 1614 'ios_rel_device_ninja': ['compile'], |
| 1616 'mac_asan': ['compile'], | 1615 'mac_asan': ['compile'], |
| 1617 #TODO(stip): Change the name of this builder to reflect that it's release. | 1616 #TODO(stip): Change the name of this builder to reflect that it's release. |
| 1618 'linux_gtk': standard_tests, | 1617 'linux_gtk': standard_tests, |
| 1619 'linux_chromeos_asan': ['compile'], | 1618 'linux_chromeos_asan': ['compile'], |
| 1619 'linux_chromium_asan_rel': ['defaulttests'], |
| 1620 'linux_chromium_chromeos_clang_dbg': ['defaulttests'], | 1620 'linux_chromium_chromeos_clang_dbg': ['defaulttests'], |
| 1621 'linux_chromium_chromeos_compile_dbg_ng': ['defaulttests'], |
| 1621 'linux_chromium_chromeos_rel': ['defaulttests'], | 1622 'linux_chromium_chromeos_rel': ['defaulttests'], |
| 1623 'linux_chromium_chromeos_rel_ng': ['defaulttests'], |
| 1622 'linux_chromium_compile_dbg': ['defaulttests'], | 1624 'linux_chromium_compile_dbg': ['defaulttests'], |
| 1625 'linux_chromium_compile_dbg_32_ng': ['compile'], |
| 1623 'linux_chromium_gn_dbg': ['compile'], | 1626 'linux_chromium_gn_dbg': ['compile'], |
| 1624 'linux_chromium_gn_rel': ['defaulttests'], | 1627 'linux_chromium_gn_rel': ['defaulttests'], |
| 1625 'linux_chromium_rel': ['defaulttests'], | 1628 'linux_chromium_rel': ['defaulttests'], |
| 1626 'linux_chromium_rel_ng': ['defaulttests'], | 1629 'linux_chromium_rel_ng': ['defaulttests'], |
| 1627 'linux_chromium_clang_dbg': ['defaulttests'], | 1630 'linux_chromium_clang_dbg': ['defaulttests'], |
| 1628 'linux_gpu': ['defaulttests'], | 1631 'linux_gpu': ['defaulttests'], |
| 1629 'linux_nacl_sdk_build': ['compile'], | 1632 'linux_nacl_sdk_build': ['compile'], |
| 1630 'mac_chromium_compile_dbg': ['defaulttests'], | 1633 'mac_chromium_compile_dbg': ['defaulttests'], |
| 1634 'mac_chromium_compile_dbg_ng': ['defaulttests'], |
| 1631 'mac_chromium_rel': ['defaulttests'], | 1635 'mac_chromium_rel': ['defaulttests'], |
| 1632 'mac_chromium_rel_ng': ['defaulttests'], | 1636 'mac_chromium_rel_ng': ['defaulttests'], |
| 1633 'mac_gpu': ['defaulttests'], | 1637 'mac_gpu': ['defaulttests'], |
| 1634 'mac_nacl_sdk_build': ['compile'], | 1638 'mac_nacl_sdk_build': ['compile'], |
| 1635 'win_chromium_compile_dbg': ['defaulttests'], | 1639 'win_chromium_compile_dbg': ['defaulttests'], |
| 1636 'win_chromium_dbg': ['defaulttests'], | 1640 'win_chromium_dbg': ['defaulttests'], |
| 1637 'win_chromium_rel': ['defaulttests'], | 1641 'win_chromium_rel': ['defaulttests'], |
| 1638 'win_chromium_rel_ng': ['defaulttests'], | 1642 'win_chromium_rel_ng': ['defaulttests'], |
| 1639 'win_chromium_x64_rel': ['defaulttests'], | 1643 'win_chromium_x64_rel': ['defaulttests'], |
| 1640 'win_chromium_x64_rel_ng': ['defaulttests'], | 1644 'win_chromium_x64_rel_ng': ['defaulttests'], |
| (...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1679 | 1683 |
| 1680 def GetPreferredTryMasters(project, change): | 1684 def GetPreferredTryMasters(project, change): |
| 1681 import re | 1685 import re |
| 1682 files = change.LocalPaths() | 1686 files = change.LocalPaths() |
| 1683 | 1687 |
| 1684 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files): | 1688 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files): |
| 1685 return {} | 1689 return {} |
| 1686 | 1690 |
| 1687 if all(re.search(r'\.(m|mm)$|(^|[\\\/_])mac[\\\/_.]', f) for f in files): | 1691 if all(re.search(r'\.(m|mm)$|(^|[\\\/_])mac[\\\/_.]', f) for f in files): |
| 1688 return GetDefaultTryConfigs([ | 1692 return GetDefaultTryConfigs([ |
| 1689 'mac_chromium_compile_dbg', | 1693 'mac_chromium_compile_dbg_ng', |
| 1690 'mac_chromium_rel_ng', | 1694 'mac_chromium_rel_ng', |
| 1691 ]) | 1695 ]) |
| 1692 if all(re.search('(^|[/_])win[/_.]', f) for f in files): | 1696 if all(re.search('(^|[/_])win[/_.]', f) for f in files): |
| 1693 return GetDefaultTryConfigs([ | 1697 return GetDefaultTryConfigs([ |
| 1694 'win_chromium_dbg', | 1698 'win_chromium_dbg', |
| 1695 'win_chromium_rel', | 1699 'win_chromium_rel', |
| 1696 'win8_chromium_rel', | 1700 'win8_chromium_rel', |
| 1697 ]) | 1701 ]) |
| 1698 if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) for f in files): | 1702 if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) for f in files): |
| 1699 return GetDefaultTryConfigs([ | 1703 return GetDefaultTryConfigs([ |
| 1700 'android_aosp', | 1704 'android_aosp', |
| 1701 'android_dbg_tests_recipe', | 1705 'android_dbg_tests_recipe', |
| 1702 ]) | 1706 ]) |
| 1703 if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files): | 1707 if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files): |
| 1704 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator']) | 1708 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator']) |
| 1705 | 1709 |
| 1706 builders = [ | 1710 builders = [ |
| 1711 'android_aosp', |
| 1707 'android_arm64_dbg_recipe', | 1712 'android_arm64_dbg_recipe', |
| 1708 'android_chromium_gn_compile_rel', | 1713 'android_chromium_gn_compile_rel', |
| 1709 'android_chromium_gn_compile_dbg', | 1714 'android_chromium_gn_compile_dbg', |
| 1710 'android_clang_dbg_recipe', | 1715 'android_clang_dbg_recipe', |
| 1711 'android_dbg_tests_recipe', | 1716 'android_dbg_tests_recipe', |
| 1712 'ios_dbg_simulator', | 1717 'ios_dbg_simulator', |
| 1713 'ios_rel_device', | 1718 'ios_rel_device', |
| 1714 'ios_rel_device_ninja', | 1719 'ios_rel_device_ninja', |
| 1715 'linux_chromium_chromeos_rel', | 1720 'linux_chromium_asan_rel', |
| 1721 'linux_chromium_chromeos_compile_dbg_ng', |
| 1722 'linux_chromium_chromeos_rel_ng', |
| 1723 'linux_chromium_compile_dbg_32_ng', |
| 1716 'linux_chromium_gn_dbg', | 1724 'linux_chromium_gn_dbg', |
| 1717 'linux_chromium_gn_rel', | 1725 'linux_chromium_gn_rel', |
| 1718 'linux_chromium_rel_ng', | 1726 'linux_chromium_rel_ng', |
| 1719 'linux_gpu', | 1727 'linux_gpu', |
| 1720 'mac_chromium_compile_dbg', | 1728 'mac_chromium_compile_dbg_ng', |
| 1721 'mac_chromium_rel_ng', | 1729 'mac_chromium_rel_ng', |
| 1722 'mac_gpu', | 1730 'mac_gpu', |
| 1723 'win_chromium_compile_dbg', | 1731 'win_chromium_compile_dbg', |
| 1724 'win_chromium_rel', | 1732 'win_chromium_rel', |
| 1725 'win_chromium_x64_rel', | 1733 'win_chromium_x64_rel', |
| 1726 'win_gpu', | 1734 'win_gpu', |
| 1727 'win8_chromium_rel', | 1735 'win8_chromium_rel', |
| 1728 ] | 1736 ] |
| 1729 | 1737 |
| 1730 # Match things like path/aura/file.cc and path/file_aura.cc. | 1738 # Match things like path/aura/file.cc and path/file_aura.cc. |
| 1731 # Same for chromeos. | 1739 # Same for chromeos. |
| 1732 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files): | 1740 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files): |
| 1733 builders.extend([ | 1741 builders.extend([ |
| 1734 'linux_chromeos_asan', | 1742 'linux_chromeos_asan', |
| 1735 ]) | 1743 ]) |
| 1736 | 1744 |
| 1737 # If there are gyp changes to base, build, or chromeos, run a full cros build | |
| 1738 # in addition to the shorter linux_chromeos build. Changes to high level gyp | |
| 1739 # files have a much higher chance of breaking the cros build, which is | |
| 1740 # differnt from the linux_chromeos build that most chrome developers test | |
| 1741 # with. | |
| 1742 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files): | |
| 1743 builders.extend(['cros_x86']) | |
| 1744 | |
| 1745 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | |
| 1746 # unless they're .gyp(i) files as changes to those files can break the gyp | |
| 1747 # step on that bot. | |
| 1748 if (not all(re.search('^chrome', f) for f in files) or | |
| 1749 any(re.search('\.gypi?$', f) for f in files)): | |
| 1750 builders.extend(['android_aosp']) | |
| 1751 | |
| 1752 return GetDefaultTryConfigs(builders) | 1745 return GetDefaultTryConfigs(builders) |
| OLD | NEW |