Green sky tests on the asan bot.

Green sky tests on the asan bot.

Skipped tests were not getting skipped because
the code gets whether the build is a debug or release
build from the configuration commandline argument, but
the asan bots pass Release_asan. Instead, read the
debug vs. release state from gn args instead of inferring
it from the out directory.

R=eseidel@chromium.org, esprehn@chromium.org, sky@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/50c6976769102268a751f9401f2d3d492280b1bd

[ojan, 2014-12-08 17:45:41]

ojan@chromium.org changed reviewers:
+ eseidel@chromium.org, sky@chromium.org

[ojan, 2014-12-08 17:45:41]

With gclient, your out/Debug or out/Release actually controlled whether it was a
debug or release build. test_sky/run_webkit_test used that assumption to figure
out whether the build was debug or release. This patch extends the hack a bit to
get the asan bots working for now.

Ideally gn would stick something in the output directory to say which
configuration it is so that test_sky could read that in.

In either case, this cludges together a hacky fix for now.

[ojan, 2014-12-08 17:54:47]

To be clear, I did audit all the uses of this commandline argument. This is the
only one that isn't expecting it to be the directory.

[esprehn, 2014-12-08 18:12:30]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2014-12-08 18:12:30]

lgtm

[sky, 2014-12-08 18:15:53]

https://codereview.chromium.org/754673003/diff/1/sky/tools/webkitpy/layout_te...
File sky/tools/webkitpy/layout_tests/port/base.py (right):

https://codereview.chromium.org/754673003/diff/1/sky/tools/webkitpy/layout_te...
sky/tools/webkitpy/layout_tests/port/base.py:1162: configuration =
self._options.configuration.lower().split('_')[0]
Current formatting is [android_|chromeos_]Debug|Release[_asan] (in
mojo/tools/mopy/paths.py). Maybe this should explicitly look for Debug or
Release?

[eseidel, 2014-12-08 18:18:37]

gn does stick sometihng in the output dir, gn args has an asan flag.  test_sky
can read gn args :)

[ojan, 2014-12-08 18:37:56]

On 2014/12/08 at 18:18:37, eseidel wrote:
> gn does stick sometihng in the output dir, gn args has an asan flag.  test_sky
can read gn args :)

Lol. Yes. I've fixed it to do this now. Please take a look.

[eseidel, 2014-12-08 18:58:26]

lgtm

[eseidel, 2014-12-08 18:58:27]

lgtm

lgtm

I'm not sure what the canonical way to do gn arg testing from python is, but we
should probably write a (tiny) library to do it at some point.

[sky, 2014-12-08 18:59:03]

LGTM

[ojan, 2014-12-08 19:15:17]

Committed patchset #3 (id:40001) manually as
50c6976769102268a751f9401f2d3d492280b1bd (presubmit successful).