Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: sky/tools/webkitpy/layout_tests/port/base.py

Issue 754673003: Green sky tests on the asan bot. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: read gn args Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/webkitpy/layout_tests/port/base.py
diff --git a/sky/tools/webkitpy/layout_tests/port/base.py b/sky/tools/webkitpy/layout_tests/port/base.py
index 18f0303050faa011936d277ae64b9e06ecde411a..9227ac66ad8f23eae644be168942ec75b701cf6c 100644
--- a/sky/tools/webkitpy/layout_tests/port/base.py
+++ b/sky/tools/webkitpy/layout_tests/port/base.py
@@ -1159,7 +1159,17 @@ class Port(object):
def test_configuration(self):
"""Returns the current TestConfiguration for the port."""
if not self._test_configuration:
- self._test_configuration = TestConfiguration(self._version, self._architecture, self._options.configuration.lower())
+ gn_args = self._executive.run_command([
+ 'gn', 'args',
+ self._build_path_with_configuration(self._options.configuration),
+ '--list', '--short'])
+
+ if 'is_debug = true' in gn_args:
+ configuration = 'debug'
+ else:
+ configuration = 'release'
+
+ self._test_configuration = TestConfiguration(self._version, self._architecture, configuration)
return self._test_configuration
# FIXME: Belongs on a Platform object.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698