Issue 75463008: Revert 162247 "Revert 162180 "[Refactoring] Remove include "core..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 75463008: Revert 162247 "Revert 162180 "[Refactoring] Remove include "core..." (Closed)

Created:
7 years, 1 month ago by Zhenyao Mo

Modified:
7 years, 1 month ago

Reviewers:
Zhenyao Mo

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

More Reviews

Description

Revert 162247 "Revert 162180 "[Refactoring] Remove include "core..." Reland as reverting breaking all builders. > Revert 162180 "[Refactoring] Remove include "core/inspector/Insp..." > > One of the two CLs that might cause fast/frames/seamless/seamless-nested-crash.html to timeout in debug. Can't reproduce locally, so attempting reverting to confirm. Will reland if wrong. > > > [Refactoring] Remove include "core/inspector/InspectorInstrumentation.h" from SelectorChecker.h > > > > To make it possible to add include "StyleResolver.h" to StyleEngine.h, > > We need to remove the above include from SelectorChecker.h. > > > > BUG=305885 > > TEST=No layout tests, just refactoring. > > > > Review URL: https://codereview.chromium.org/70063005 > > TBR=tasak@google.com > > Review URL: https://codereview.chromium.org/73623006 TBR=zmo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162248

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -18 lines)			Patch
M	trunk/Source/core/animation/css/CSSAnimations.cpp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	trunk/Source/core/css/ElementRuleCollector.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/Source/core/css/FontFaceSet.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/Source/core/css/SelectorChecker.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	trunk/Source/core/dom/Element.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/Source/core/dom/Node.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	trunk/Source/core/dom/SelectorQuery.cpp	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	trunk/Source/core/dom/StyleEngine.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/Source/core/dom/StyleSheetScopingNodeList.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/Source/core/dom/StyleSheetScopingNodeList.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/Source/core/inspector/InspectorCSSAgent.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/Source/core/rendering/RenderRegion.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r162248.

Expand Messages | Collapse Messages